HomeWildfire Games

Disjoint save and load GUI page.
AuditedrP20537

Description

Disjoint save and load GUI page.
Include the entire directory as in D619.

Details

Event Timeline

s0600204 raised a concern with this commit.Aug 31 2018, 8:11 PM
s0600204 added a subscriber: s0600204.

Due to the move to a differently named folder, the strings marked for translation contained within load.{js|xml} are no longer being picked up for translation.

mods/public/l10n/message.json should be updated. (Section "public-gui-other")

(Attribution for discovery should go to Requin on the forums (link))

This commit now has outstanding concerns.Aug 31 2018, 8:11 PM
elexis added a comment.EditedAug 31 2018, 9:49 PM

Attribution for discovery

Reported by GunChleoc https://wildfiregames.com/forum/index.php?/topic/24321-untranslatable-strings/ and patched at #5155

My apologies. Rediscovered by Requin. (And that patch... yeesh.)

Still, when it's fixed, I'll accept this and its sibling. Until then, it'll serve as a reminder, if only to myself.

elexis requested verification of this commit.Dec 28 2018, 2:17 PM

Sorry for the stupid failure, should be fixed by rP21960.

This commit now requires verification by auditors.Dec 28 2018, 2:17 PM
s0600204 accepted this commit.Jan 10 2019, 6:02 PM
All concerns with this commit have now been addressed.Jan 10 2019, 6:02 PM