HomeWildfire Games

New mushrooms for maps;
AuditedrP21099

Description

New mushrooms for maps;

Discussed with : elexis, Imarok, fpre
Request by : FeXoR

Details

Auditors
elexis
Committed
StanFeb 2 2018, 12:48 AM
Parents
rP21098: Fix wrong biome JS function name following rP21010, refs #4954.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 4791
Build 8307: Post-Commit BuildJenkins

Event Timeline

elexis raised a concern with this commit.Feb 7 2018, 4:54 PM
elexis added a subscriber: elexis.

I'm impressed by the models, but not by the directory name flora, since fungi aren't flora. Looks like moving the one directory should be sufficient. Call it fungi or mushrooms? I suspect the former would be more in line with the flora and fauna directory.

svn mv binaries/data/mods/public/art/actors/flora/mushrooms binaries/data/mods/public/art/actors/fungi

Also is it intended that flora only contains the trees subdirectory while the bushes like bush_desert_a.xml remain in art/actors/props/flora/?

This commit now has outstanding concerns.Feb 7 2018, 4:54 PM
elexis added a comment.Feb 7 2018, 4:59 PM

Also, I just noticed that those trees which looked like birches are, according to the template name, supposed to be beeches. So maybe we could write up a possible art task on the forums or trac to create birch trees.

Stan added a comment.Feb 7 2018, 10:01 PM

Call it fungi or mushrooms? I suspect the former would be more in line with the flora and fauna directory.

svn mv binaries/data/mods/public/art/actors/flora/mushrooms binaries/data/mods/public/art/actors/fungi

Yeah sure. will change it if you like. Not sure if it's worth it, nor if that's worth raising a concern either. Would it make more sense to move it to the prop folder ?
See below.

Also is it intended that flora only contains the trees subdirectory while the bushes like bush_desert_a.xml remain in art/actors/props/flora/?

Not really as both of those are by definition props. Would such a change be worth it. I can't tell.

Also, I just noticed that those trees which looked like birches are, according to the template name, supposed to be beeches. So maybe we could write up a possible art task on the >forums or trac to create birch trees.

The task already exists in the update post here : https://wildfiregames.com/forum/index.php?/topic/17730-art-dev-task-tracking/ in the flora subsection.

elexis accepted this commit.Feb 10 2018, 6:15 PM

Fixed in rP21172, thanks

All concerns with this commit have now been addressed.Feb 10 2018, 6:15 PM
elexis added a subscriber: lyv.Mar 9 2018, 4:12 AM

I've added them to Hellas, but I didn't notice them yet (can be a placement bug too).
Hopefully we can add them to Danubius for the release (maybe @smiley volunteers?)