HomeWildfire Games

Set victory conditions for autostart games.
AuditedrP21108

Description

Set victory conditions for autostart games.

Reviewed By: elexis

Trac Tickets: #5016

Differential Revision: https://code.wildfiregames.com/D1278

Details

Auditors
elexis
Committed
mimoFeb 3 2018, 8:39 PM
Reviewer
elexis
Differential Revision
D1278: fix autostart for missing GameType
Parents
rP21107: Diplomacy Colors
Branches
Unknown
Tags
Unknown
Build Status
Buildable 4805
Build 8331: Trigger Windows Autobuild
Build 8330: Post-Commit BuildJenkins

Event Timeline

elexis added a subscriber: elexis.Mar 10 2018, 12:00 PM

Did this remove the possibility to start endless games and should have a hardcoded check for endless? (Noticed in D1240)

@mimo The conquest default as is is a problem, because it prevents endless games on random and skirmish maps.
But endless games are useful, for example for running survival of the fittest, jebel barkal or danubius with dryRun = true and debugLog = true in the trigger script shows a summary of the templates spawned.

So I (or you if you prefer) can either:

  • remove the default Conquest and just have it log the loaded victory conditions (to inform the user that it's an endless game),
  • or implement an --endless argument which would set an empty vector to victoryConditions (even if other victory conditions are passed)
elexis raised a concern with this commit.Mar 28 2018, 6:16 PM

(I flag it as a concern so I don't forget about it again.)

This commit now has outstanding concerns.Mar 28 2018, 6:16 PM
mimo added a comment.Mar 28 2018, 7:29 PM

@mimo The conquest default as is is a problem, because it prevents endless games on random and skirmish maps.
So I (or you if you prefer) can either:

  • remove the default Conquest and just have it log the loaded victory conditions (to inform the user that it's an endless game),
  • or implement an --endless argument which would set an empty vector to victoryConditions (even if other victory conditions are passed)

then maybe removing the default (equivalent to having endless as default) would be cleaner.

bb added a subscriber: bb.May 9 2018, 12:53 PM

endless support readded in rP21474

elexis added a comment.May 9 2018, 1:16 PM
In rP21108#30645, @bb wrote:

endless support readded in rP21474

Ah, nice, I forgot that.
(Then we only need to update the two descriptions in one a24 commit to fix both commits with missing victory condition description updates.)

/ps/trunk/source/ps/GameSetup/GameSetup.cpp
1158

While fixing the description:
This changed the copy in GameSetup.cpp but not the copy in README.txt.
(Just want to mention again that the unneeded extra maintenance cost and error-proneness would be gone with D1433.)

elexis accepted this commit.Mar 16 2019, 5:54 PM

Thanks for the documentation fix!

All concerns with this commit have now been addressed.Mar 16 2019, 5:54 PM