HomeWildfire Games

Update the templates to match the new unit names.
AuditedrP21202

Description

Update the templates to match the new unit names.
Rename ptol cavalry to camelry to better reflect what they are.
Update the maps accordingly.

Details

Auditors
mimo
Provenance
StanAuthored on
Parents
rP21201: Cleanup of the units PART XIV
Branches
Unknown
Tags
Unknown
Build Status
Buildable 4951
Build 8545: Post-Commit BuildJenkins

Event Timeline

Rename ptol cavalry to camelry to better reflect what they are.

Not sure about that.
Then the cavalry identity class has to be removed too? And the cavalry upgrades now affect cavalry and camelry? And the attack bonus of spearmen works against cavalry and camelry?
fatherbushido often spoke of mounted units (which would also include elephants)

Currently they are treated as cavalry. I didn't want to change that as it affects balancing and AI and it's far beyond the scope and my knowledge.

mimo raised a concern with this commit.Feb 13 2018, 9:30 PM
mimo added a subscriber: mimo.

I'm also not convinced by that renaming to camelry. Such a change should be discussed before (possibly with a phabricator patch).
Futhermore, i'm pretty sure this will break the skirmish replacement for ptol.

If something must be changed, it is inside the kushites: they have to my mind too many units, and some cleaning must be done there, not modifying and breaking all the rest without any discussion.

This commit now has outstanding concerns.Feb 13 2018, 9:30 PM

I'll revert the camelry renaming if that's okay then ?

In rP21202#28184, @Stan wrote:

I'll revert the camelry renaming if that's okay then ?

That looks as the safer way, otherwise you'd need to change the way skirmish replacement is done by testing on the existence of the cavalry or camel to decide which one to use.

But i'm not sure that's needed: the origin of that separation is that the kush have two cavalry_javelin (one camel and one horse). I'm not sure we really need both (at least for a23), and if really felt needed, switch one of them as mercenary and that's done. No need for the extra complication of separating camelry and cavalry.

Camel is indeed gonna be mercenary
It's either gonna be for the blemmye or nuba camps.

All concerns with this commit have now been addressed.Feb 15 2018, 8:13 PM