Refactor and move random template composition triggerscript code used for gaia…
rP21445
Actions

Description

Refactor and move random template composition triggerscript code used for gaia attacker waves from Danubius (rP19434 / D204) and Survival Of The Fittest (rP19359 / D145) to the TriggerHelper.

Eases implementation of new maps with diverse scripted attackers, refs #5040, D11 and map difficulties, refs #4963, D1189.
Replaces hardcoded templatenames with calls to a new TriggerHelper function to query template names, given Classes, Civ, Rank or Packed state.
Removes the duplicated template counting logic, that was intertwined with map specific unit classes balancing logic, refs #4805.

Use mimos garrison function from rP20659 / D1146 to support doubleclicking on garrisoned gaia heroes on Danubius, fixing the bug described in comment:10 of #4291.
Fix wrong (Trigger) prototype reference in rP21416.

Details

Committed

elexis

Mar 6 2018, 2:31 PM

Parents

rP21444: Small map cleanup and performance improvements.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 5361
Build 9096: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP21445: Refactor and move random template composition triggerscript code used for gaia….Mar 6 2018, 2:31 PM

Harbormaster completed building B5361: rP21445: Refactor and move random template composition triggerscript code used for gaia….Mar 6 2018, 3:25 PM

elexis marked an inline comment as done.Dec 8 2018, 3:39 PM

elexis added inline comments.

/ps/trunk/binaries/data/mods/public/maps/random/danubius_triggers.js
638	Initializing the variables at `OnInitGame` rather than immediately breaks when starting the game with disabled treasures, (only then?) calling the ownershipchanged-handler prior to the init of the variables used in the handler.