HomeWildfire Games
Diffusion 0 A.D. Public Repository rP21537

Remedy typo in r21101 identified by temple
AuditedrP21537
Actions

Description

Remedy typo in r21101 identified by temple

Refs: rP21101
Concerned: temple

Details

Auditors
Silier
Committed
s0600204Mar 13 2018, 7:54 PM
Parents
rP21536: Make the conquest dropdown uncheck the conquest_structures/units checkboxes…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 5530
Build 9330: Post-Commit BuildJenkins

Event Timeline

s0600204 committed rP21537: Remedy typo in r21101 identified by temple.Mar 13 2018, 7:54 PM
s0600204 mentioned this in rP21101: Add a couple of string manipulation functions to globalscripts..Mar 13 2018, 7:55 PM
temple added a subscriber: temple.Mar 13 2018, 8:23 PM
temple added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js
38

slice too

Harbormaster completed building B5530: rP21537: Remedy typo in r21101 identified by temple.Mar 13 2018, 8:49 PM
s0600204 mentioned this in rP21539: Remedy the other typo in r21101 identified by temple.Mar 13 2018, 8:50 PM
s0600204 marked an inline comment as done.Mar 13 2018, 8:52 PM
Silier raised a concern with this commit.EditedMar 13 2018, 9:54 PM
Silier added a subscriber: Silier.

starting map - no entities loaded with errors:

ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/sele_civil_centre'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/pers_civil_centre'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/gaul_civil_centre'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_infantry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_infantry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_cavalry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_infantry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_infantry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_cavalry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_cavalry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_infantry_archer_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_infantry_archer_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/sele_civil_centre'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/pers_civil_centre'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/gaul_civil_centre'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_infantry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/sele_cavalry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_support_female_citizen'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_infantry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/gaul_cavalry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_cavalry_javelinist_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_infantry_spearman_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_infantry_archer_b'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|units/pers_support_female_citizen'

WARNING: PlayerID 2 | Petra error: it does not know how to interpret this map WARNING: PlayerID 3 | Petra error: it does not know how to interpret this map
This commit now has outstanding concerns.Mar 13 2018, 9:54 PM
mimo added a subscriber: mimo.Mar 13 2018, 10:03 PM

Same problem here, but curiously only starting docks give error. On islands map, we get

ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/athen_dock'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/cart_dock'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/brit_dock'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/rome_dock'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/athen_dock'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/cart_dock'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/brit_dock'
ERROR: Invalid subset ''
ERROR: Failed to load entity template '|structures/rome_dock'
Silier added a comment.Mar 13 2018, 10:10 PM

Scenarios looks ok
Skirmish gets error

mimo added a comment.Mar 13 2018, 10:12 PM
In rP21537#29524, @Angen wrote:

Scenarios looks ok
Skirmish gets error

yep skirmish replacement is done on skirmish and random. My errors were on a random map.

Silier added a comment.Mar 13 2018, 10:13 PM
In rP21537#29525, @mimo wrote:
In rP21537#29524, @Angen wrote:

Scenarios looks ok
Skirmish gets error

yep skirmish replacement is done on skirmish and random. My errors were on a random map.

Yeah, I got it after I loked at file placement and name :D

s0600204 mentioned this in rP21544: Finally fix typo reported in r21101/r21537 (3rd time lucky).Mar 13 2018, 11:14 PM
s0600204 requested verification of this commit.Mar 13 2018, 11:15 PM

(Hopefully) fixed in rP21544.

This commit now requires verification by auditors.Mar 13 2018, 11:15 PM
temple added a comment.Mar 13 2018, 11:39 PM

Yep, oops. I was expecting to use the previous formula so I didn't think it through enough.

Silier accepted this commit.Mar 14 2018, 3:38 PM

rP21544 fixes errors

All concerns with this commit have now been addressed.Mar 14 2018, 3:38 PM

Changes (1)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/

rP21537

View Options

ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js

Loading...
Wildfire Games · Phabricator