HomeWildfire Games

Update mod_ipstamp for current ejabberd versions and update lobby setup…

Description

Update mod_ipstamp for current ejabberd versions and update lobby setup instructions.

Patch By: Dunedan
Differential Revision: https://code.wildfiregames.com/D1208

Details

Event Timeline

elexis added a subscriber: elexis.Oct 28 2018, 2:05 AM

Includes markup conversion patch by user1 from D280.

/ps/trunk/source/tools/XpartaMuPP/README.md
12

I can confirm that the ejabberd 16.01, which comes with ubuntu 16.04 does not recognize the ipstamp module specs. ( https://packages.ubuntu.com/de/xenial/ejabberd).

Since the first 10 lines of the document can be safely skipped by the reader (self-exlanatory), skipping the 11th line can have terrible consequences, a day lost looking for an ejabberd error message which never occurs.

So I suggest to add a new code step, so that people are forced to consider the version:

Confirm that you have an ejabberd version of 17.03 or more recent:

$ ejabberdctl status

Also it might be useful to mention which specific part requires that version if that is known.

145

Phrasing of the last sentence a bit odd / too brief. There should be ejabberd config entries here as well.

elexis added inline comments.Oct 29 2018, 4:59 PM
/ps/trunk/source/tools/XpartaMuPP/README.md
143

To enable the bot to send the game list to players it needs the JIDs of the players, so the MUC room has to be configured as non-anonymous room.

The conclusion is wrong, because the muc_admin setting already grants that privilege to bots, even if the channel is configured as semi-anonymous.
On lobby.wildfiregames.com it is also set to "semi-anonymous", i.e. only moderators and bots being able to see the real JID.

refs https://xmpp.org/extensions/xep-0045.html#enter-nonanon

145

It would be:

    modules:
      mod_muc:
	      access_admin: muc_admin

    access_rules:
      muc_admin:
        - allow: bots

It seems wrong to give bots muc administrator rights only to see the real JID.
If the room is configured as non-anonymous, they can see the real JID without being administrator and hosting works well, tested locally.

So instead I propose:

modules:
  mod_muc:
    default_room_options:
      anonymous: false
elexis added inline comments.Oct 29 2018, 5:15 PM
/ps/trunk/source/tools/XpartaMuPP/mod_ipstamp/COPYING
1

If this isn't an unneeded copy, then it at least is inconsistent with all the other source/tools/ directories (or even /?) no?

Files source/tools/XpartaMuPP/mod_ipstamp/COPYING and license_gpl-2.0.txt are identical

and source/tools/LICENSE.txt already says

XpartaMuPP

GPL version 2 (or later)