ShouldConsiderOurselvesAtDestination renamed to…
Needs VerificationrP22299
Actions

Description

ShouldConsiderOurselvesAtDestination renamed to CloseEnoughFromDestinationToStop and stateful effects moved at the caller.

It improves readability of the code when a function that seems like it does a simple check actually only does a simple check and the caller is the one changing state.

Differential Revision: https://code.wildfiregames.com/D1884

Details

Auditors

elexis

Committed

wraitii

May 25 2019, 3:23 PM

Differential Revision

D1884: UnitMotion - improve the name of a function and move stateful effects at the caller.

Parents

rP22298: Health.js cleanup: add tests, add an "IsInjured" function, use this.hitpoints…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 7581
Build 12357: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22299: ShouldConsiderOurselvesAtDestination renamed to….May 25 2019, 3:23 PM

Harbormaster completed building B7581: rP22299: ShouldConsiderOurselvesAtDestination renamed to….May 25 2019, 4:18 PM

ShouldConsiderOurselvesAtDestination from rP17226.
Agree with that previous name being broken because this is only about the unit, not about the reader.

function that seems like it does a simple check actually only does a simple check and the caller is the one changing state.

Then rename the function and update the comments to indicate that this function does something instead of adding duplication.

This commit now has outstanding concerns.Jun 24 2019, 4:07 PM

The reason why I moved the stateful calls outside the functions was mostly in planning of further diffs, which remove StopMoving() and "FacePointAfterMove", i.e. the duplication.

These two commits have been merged already and it now looks like this:

This duplication of MoveSucceeded isn't necessarily going to remain forever either since PathResult might want to do something different there instead.
My opinion is that this concern has already been fixed.

wraitii requested verification of this commit.Jul 19 2019, 2:45 PM

This commit now requires verification by auditors.Jul 19 2019, 2:45 PM

Changes (1)

Path

Size

ps/

trunk/

source/

simulation2/

components/

CCmpUnitMotion.cpp

rP22299

View Options

ps/trunk/source/simulation2/components/CCmpUnitMotion.cpp