HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22316

Cleanup MikktspaceWrapper.
rP22316
Actions

Description

Cleanup MikktspaceWrapper.

Reviewed by: @Angen

Differential Revision: https://code.wildfiregames.com/D1872

Details

Committed
StanMay 29 2019, 12:06 AM
Reviewer
Silier
Differential Revision
D1872: Cleanup MikktspaceWrap
Parents
rP22315: New horse and cattle fauna template corrections
Branches
Unknown
Tags
Unknown
Build Status
Buildable 7659
Build 12488: Post-Commit BuildJenkins

Event Timeline

Stan committed rP22316: Cleanup MikktspaceWrapper..May 29 2019, 12:06 AM
Stan added a subscriber: Silier.
vladislavbelov added a subscriber: vladislavbelov.May 29 2019, 12:24 AM
vladislavbelov added inline comments.
/ps/trunk/source/renderer/MikktspaceWrap.cpp
100

Different style for the constant reference here and below.

/ps/trunk/source/renderer/MikktspaceWrap.h
21

Why the includes were added in the header instead of forward declaration?

28

No empty line before the class definition.

40

I don't think that it makes much sense, because they're related.

/ps/trunk/source/renderer/ModelRenderer.cpp
120

Spaces.

Stan mentioned this in D1934: Further cleanup for MikkTspace..May 29 2019, 12:32 AM
Stan added inline comments.
/ps/trunk/source/renderer/MikktspaceWrap.cpp
100

See D1934

/ps/trunk/source/renderer/MikktspaceWrap.h
21

Cause forward declaration doesn't work, as the classes are used as class attributes.

28

Should there be ?

40

Each of them was on a newline so no strong feeling.

Harbormaster completed building B7659: rP22316: Cleanup MikktspaceWrapper..May 29 2019, 12:38 AM
vladislavbelov added inline comments.May 29 2019, 12:43 AM
/ps/trunk/source/renderer/MikktspaceWrap.h
21

Did you try it? Because it should work for constant references.

Stan added inline comments.May 29 2019, 8:11 AM
/ps/trunk/source/renderer/MikktspaceWrap.h
21

I did but I'll try again.

vladislavbelov mentioned this in rP12300: ao/parallax/normal/specular/emissive mapping; windy trees; time manager; render….Jul 2 2019, 3:45 PM

Changes (3)

PathSize
ps/
trunk/
source/
renderer/

rP22316

View Options

ps/trunk/source/renderer/MikktspaceWrap.cpp

Loading...
View Options

ps/trunk/source/renderer/MikktspaceWrap.h

Loading...
View Options

ps/trunk/source/renderer/ModelRenderer.cpp

Loading...
Wildfire Games · Phabricator