HomeWildfire Games
Diffusion 0 A.D. Public Repository rP22414

Fix rP22367, make units again properly hunt animals that died in FoW.
rP22414
Actions

Description

Fix rP22367, make units again properly hunt animals that died in FoW.

The reason was that the unit immediately tried gathering nearby instead of going to the unit's last known position.

Related to D1997.

Differential Revision: https://code.wildfiregames.com/D1996

Details

Committed
wraitiiJun 30 2019, 8:55 PM
Differential Revision
D1996: Make units properly hunt animals that died in FoW
Parents
rP22413: Fix some animals "roaming" state not working correctly (units seem stuck in…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 8134
Build 13245: Post-Commit BuildJenkins

Event Timeline

wraitii committed rP22414: Fix rP22367, make units again properly hunt animals that died in FoW..Jun 30 2019, 8:55 PM
Harbormaster completed building B8134: rP22414: Fix rP22367, make units again properly hunt animals that died in FoW..Jun 30 2019, 9:54 PM
elexis raised a concern with this commit.Jul 1 2019, 1:59 PM
elexis added a subscriber: elexis.

Error: ReferenceError
Reproduce: Run the committed code.

This commit now has outstanding concerns.Jul 1 2019, 1:59 PM
wraitii added a comment.Jul 1 2019, 7:09 PM

Fixed in D2032

wraitii mentioned this in rP22421: Fix rP22414: s/target/this.gatheringTarget.Jul 1 2019, 9:02 PM
elexis removed an auditor: elexis.Jul 1 2019, 9:40 PM

(error was)

ERROR: Error in timer on entity 7087, IID96, function TimerHandler: ReferenceError: target is not defined
  UnitAI.prototype.UnitFsmSpec.INDIVIDUAL.GATHER.GATHERING.Timer@simulation/components/UnitAI.js:2224:12
  FSM.prototype.ProcessMessage@simulation/helpers/FSM.js:265:12
  UnitAI.prototype.TimerHandler@simulation/components/UnitAI.js:3739:2
  Timer.prototype.OnUpdate@simulation/components/Timer.js:120:4
This commit no longer requires audit.Jul 1 2019, 9:40 PM

Changes (1)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
components/

rP22414

View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...
Wildfire Games · Phabricator