Diffusion 0 A.D. Public Repository rP22415

Unit Motion - Stop when targets have an invalid position.
rP22415
Actions

Description

Unit Motion - Stop when targets have an invalid position.

Previously, unitMotion had no code that checked particularly if the target was still in the world.
When the target moved out of the world, unitMotion would follow the path to its last known position, then send a "MoveSucceeded" message once there.

Following rP22366, this message was no longer sent. Thus unit would follow their path to its last waypoint and stay there, unable to carry on or finish the order. UnitMotion now explcitly sends a "MoveFailed" message.

This still changes behaviour from A23, requiring further revisions to UnitAI (see D1992 for one such case).

Minohaka tested an earlier version of this change (which incorporated D1992) and accepted it.

Differential Revision: https://code.wildfiregames.com/D1979

Details

Committed

wraitii

Jun 30 2019, 9:00 PM

Differential Revision

D1979: Unit Motion - account for entity moving out of world

Parents

rP22414: Fix rP22367, make units again properly hunt animals that died in FoW.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8135
Build 13247: Trigger Windows Autobuild
Build 13246: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22415: Unit Motion - Stop when targets have an invalid position..Jun 30 2019, 9:00 PM

Harbormaster completed building B8135: rP22415: Unit Motion - Stop when targets have an invalid position..Jun 30 2019, 10:24 PM

Reproduce:

Select starting units
Set them to gather chicken

Expected result:

2 units gather from the target chicken
the other units gather from nearby chicken

Observed result:

2 units gather from the target chicken
The other units stop on their way once the target is dead

Before this commit:

2 units gather from the target chicken
The othe runits walk to the targe chicken and look at it idle
Bisecting shows that 22361 didn't have that bug, but 22372 has it (so it was introduced somewhere in between)

This commit now has outstanding concerns.Jul 1 2019, 2:30 PM

This Is introduced by this revision and is fixed by D1992.

Well to be perfectly exact rP22366 introduced the first breakage, as noted above. This revision changes behaviour slightly: the unit will stop in its track instead of following its waypoints. D1992 still fixes it.

wraitii mentioned this in rP22425: UnitMotion - Explicit handling of movement errors (such as target death) in….Jul 2 2019, 8:49 AM

Fixed in rP22425

elexis removed an auditor: elexis.Jul 2 2019, 12:31 PM

This commit no longer requires audit.Jul 2 2019, 12:31 PM