Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP22569

Improve Attack's GetBestAttackAgainst by only considering attack types that…
AuditedrP22569
Actions

Description

Improve Attack's GetBestAttackAgainst by only considering attack types that actually can attack the target.

Patch By: freagarach

Reviewed By: wraitii

Differential Revision: https://code.wildfiregames.com/D2112

Details

Auditors

Freagarach

Committed

wraitii

Jul 28 2019, 4:58 PM

Reviewer

wraitii

Differential Revision

D2112: Fix "GetBestAttackAgainst"-function in "Attack.js".

Parents

rP22568: UnitMotion cleanup - remove dead code, add a common path for MoveTo functions…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8643
Build 14161: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22569: Improve Attack's GetBestAttackAgainst by only considering attack types that….Jul 28 2019, 4:58 PM

Harbormaster completed building B8643: rP22569: Improve Attack's GetBestAttackAgainst by only considering attack types that….Jul 28 2019, 5:03 PM

Freagarach raised a concern with this commit.Jul 29 2019, 5:46 PM

Freagarach added a subscriber: Freagarach.

Freagarach added inline comments.

/ps/trunk/binaries/data/mods/public/simulation/components/Attack.js
415–416	If `allowCapture` is false capture ought to be spliced from the types. (D2134)

This commit now has outstanding concerns.Jul 29 2019, 5:46 PM

elexis mentioned this in D2134: Fix Capture oversight in GetBestAttackAgainst in rP22569.Jul 29 2019, 5:48 PM

wraitii mentioned this in rP22575: Fix Capture oversight in GetBestAttackAgainst in rP22569.Jul 29 2019, 8:52 PM

Fixed by rP22575.
Thanks for committing this :)

All concerns with this commit have now been addressed.Jul 29 2019, 8:55 PM

Changes (2)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

Attack.js

tests/

test_Attack.js

rP22569

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Attack.js