Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.
rP22674
Actions

Description

Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

std::thread crashes when destroyed without being joined or detached.
Joining would wait on the UPnP thread, which can take upwards of 10 seconds, so detach instead.

Reviewed By: elexis

Differential Revision: https://code.wildfiregames.com/D2181

Details

Committed

wraitii

Aug 16 2019, 7:38 PM

Reviewer

elexis

Differential Revision

D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit

Parents

rP22673: Animations re-export "Skeleton and Bodies"

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8886
Build 14582: Trigger Windows Autobuild
Build 14581: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22674: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit..Aug 16 2019, 7:38 PM

wraitii added an edge: D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.

Harbormaster completed building B8886: rP22674: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit..Aug 16 2019, 7:44 PM

I tested again multiple times...
With the joinable() test there is no warning, without the condition there is!
Also says possible leak, not definite. So perhaps its testing the not impossible per se case that the thing was only default constructed.

9669== 480 bytes in 1 blocks are possibly lost in loss record 2,785 of 3,231

So it should be good without the TODO, false alert.

(So only imaginary TODO to have this joinable by having some other library that better supports getting shutdown.)

Changes (1)

Path

Size

ps/

trunk/

source/

network/

NetServer.cpp

rP22674

View Options

ps/trunk/source/network/NetServer.cpp