Diffusion 0 A.D. Public Repository rP22666

pthread -> std::thread (4/7) - Replace pthread in remaining files
rP22666
Actions

Tags

None

Subscribers

Description

pthread -> std::thread (4/7) - Replace pthread in remaining files

This removes pthread mutexes/threads from:

vfs
the resource handler manager
timer
the network server.

This allows removing it from our general posix include header.

Differential Revision: https://code.wildfiregames.com/D1920

Details

Committed

Aug 15 2019, 11:07 AM

Differential Revision

D1920: pthread -> std::thread (4/?) - Replace pthread in remaining files

Parents

rP22665: Move manual page values back to the page itself due to a lack of that page…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8858
Build 14530: Trigger Windows Autobuild
Build 14529: Post-Commit Build	Jenkins

Event Timeline

wraitii committed rP22666: pthread -> std::thread (4/7) - Replace pthread in remaining files.Aug 15 2019, 11:07 AM

wraitii added an edge: D1920: pthread -> std::thread (4/?) - Replace pthread in remaining files.

Harbormaster completed building B8858: rP22666: pthread -> std::thread (4/7) - Replace pthread in remaining files.Aug 15 2019, 11:39 AM

Main Menu -> Host Game -> Back -> Segfault upon NetServer delete

First I thought its the patch I was about to commit.
Then I thought its the GUI patches.
Took me three hours of compiling and looking the diff in my working copy for the bug, then bisecting and compiling to find that its just 4 revisions ago. :/

This commit now has outstanding concerns.Aug 16 2019, 2:59 AM

elexis mentioned this in D2181: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit.Aug 16 2019, 11:26 AM

elexis mentioned this in rP14372: Move UPnP port forwarding to a thread..Aug 16 2019, 4:46 PM

wraitii mentioned this in rP22674: Fix rP14372 and rP22666 miniupnpc leak and crash on thread exit..Aug 16 2019, 7:39 PM

Thanks for the excursion. One should probably check whether there are other calls that need a join instead of a detach, or that miss it completely like this one did, or whether joinable() safeguards are missing (and whether every modified code actually works)

This commit no longer requires audit.Aug 16 2019, 7:48 PM

vladislavbelov added a subscriber: vladislavbelov.Feb 13 2021, 7:47 PM

vladislavbelov added inline comments.

/ps/trunk/source/lib/file/vfs/vfs.cpp
160	Fixes N13 from #5288.

Changes (7)

Path

Size

ps/

trunk/

source/

lib/

file/

vfs/

posix/

res/

network/

rP22666

ps/trunk/source/lib/file/vfs/vfs.cpp

Loading...

ps/trunk/source/lib/file/vfs/vfs.h

Loading...

ps/trunk/source/lib/posix/posix.h

Loading...

ps/trunk/source/lib/res/h_mgr.cpp

Loading...

ps/trunk/source/lib/timer.cpp

Loading...

ps/trunk/source/network/NetServer.cpp

Loading...

ps/trunk/source/network/NetServer.h

Loading...