Diffusion 0 A.D. Public Repository rP22694

Stop copying color every draw call for every GUI object using colors.
rP22694
Actions

Description

Stop copying color every draw call for every GUI object using colors.

Avoid color copies for rendering Draw calls in GUIRenderer::UpdateDrawCallCache, CButton::Draw, CChart::DrawAxes, CDropDown::Draw, CList::DrawList, COList::DrawList, refs #1984, rP1518, rP22637, rP22638.
Avoid color copies during XML loading in CGUI::Xeromyces_ReadImage, CGUI::Xeromyces_ReadEffects, COList::HandleAdditionalChildren.
Add CGUI::HasPreDefinedColor and mark m_PreDefinedColors, CGUI::GetPreDefinedColor, IGUIButtonBehavior::ChooseColor() as const for consistency with the other "databases", refs rP22637.
Mark CGUIColor as NONCOPYABLE to add compiler errors if there is an unexplicit copy, refs rP22637.
Explicit ugly copy in CGUI::Xeromyces_ReadColor and CGUIColor::ParseString.
Deregister copying <CGUIColor>GetSetting functions, refs rP1518.
Uses the const ref GetSetting from rP22693.

Details

Committed

elexis

Aug 19 2019, 2:53 PM

Differential Revision

D2193: Stop copying color every draw call for every GUI object using colors ffs

Parents

rP22693: Use a new GetSetting returning a reference instead of GetSettingPointer when…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 8925
Build 14647: Trigger Windows Autobuild
Build 14646: Post-Commit Build	Jenkins

Event Timeline

elexis committed rP22694: Stop copying color every draw call for every GUI object using colors..Aug 19 2019, 2:53 PM

Stan mentioned this in D2193: Stop copying color every draw call for every GUI object using colors ffs.Aug 19 2019, 3:08 PM

Harbormaster completed building B8925: rP22694: Stop copying color every draw call for every GUI object using colors..Aug 19 2019, 3:08 PM

elexis added an edge: D2193: Stop copying color every draw call for every GUI object using colors ffs.Aug 19 2019, 7:01 PM

elexis added inline comments.Aug 21 2019, 11:16 AM

/ps/trunk/source/gui/GUIRenderer.h
57	Notice that these members are not default-initialized at construction time anymore - however so are the bools, and the value is always assigned for the bools and pointers just after the SDrawCall is created.