Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original…
AuditedrP23215
Actions

Description

Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.
Reviewed by: @Angen
Comments by: @elexis

Differential Revision: https://code.wildfiregames.com/D2338

Details

Auditors

Itms

Committed

Stan	Dec 7 2019, 12:48 PM

Reviewer

Silier

Differential Revision

D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer

Parents

rP23214: Patch SpiderMonkey 45 against bug https://bugzilla.mozilla.org/show_bug.cgi?

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10219
Build 17355: Trigger Windows Autobuild
Build 17354: Post-Commit Build	Jenkins

Event Timeline

Stan committed rP23215: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original….Dec 7 2019, 12:48 PM

Stan added an edge: D2338: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original name. Also restore the Wrapper name to reflect what it's wrapping and move it to renderer.

Stan added subscribers: Silier, elexis.

Harbormaster completed building B10219: rP23215: Move Ogre3D GLSL Preprocessor to a third_party folder and restore its original….Dec 7 2019, 1:05 PM

Could you set svn:ignore to *.cpp on source/third_party/ogre3d_preprocessor/tests (like we do in other tests folders)? That would be great for upcoming svn sts ?

This commit now has outstanding concerns.Dec 30 2019, 10:32 AM

Stan requested verification of this commit.Dec 30 2019, 12:13 PM

This commit now requires verification by auditors.Dec 30 2019, 12:13 PM

Stan mentioned this in rP23313: Set `svn:ignore` to `*.cpp on` `source/third_party/ogre3d_preprocessor/tests`….Dec 30 2019, 12:13 PM

Thanks!

All concerns with this commit have now been addressed.Dec 30 2019, 12:17 PM