Diffusion 0 A.D. Public Repository rP23448

Allow status effect to apply modifiers and fix rP22901
rP23448
Actions

Description

Allow status effect to apply modifiers and fix rP22901

Status effect can apply modifier to the entity (armour strength, walking speed, ...)
This is also hiding status effect icons by default in selection detail.
Fixing smaller related bugs.

Differential Revision: https://code.wildfiregames.com/D2281
Patch by: @Freagarach
Comments by: Stan, wraitii

Details

Committed

Silier

Jan 27 2020, 5:51 PM

Differential Revision

D2281: Status Effects v2 - More cleanup, allow modifiers.

Parents

rP23447: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 10974
Build 19354: Post-Commit Build	Jenkins
Build 19353: Post-Commit Build (macOS)	Jenkins

Event Timeline

Silier committed rP23448: Allow status effect to apply modifiers and fix rP22901.Jan 27 2020, 5:51 PM

Silier added an edge: D2281: Status Effects v2 - More cleanup, allow modifiers..

Silier added a subscriber: Freagarach.

Silier mentioned this in rP22901: GUI support for Status Effects and extend their functionality to all attack….Jan 27 2020, 5:52 PM

Harbormaster completed building B10974: rP23448: Allow status effect to apply modifiers and fix rP22901.Jan 27 2020, 6:08 PM

Silier mentioned this in D2296: StatusEffects v3 - More cleanup, allow stackable, upgrades..Feb 20 2020, 8:10 AM

Silier mentioned this in D2647: Explicitly check for undefined when applying Auras and Technologies..Mar 1 2020, 9:18 AM

Freagarach mentioned this in D2337: Internationalise Damage Types and Status Effects using (optional) JSON files..Mar 17 2020, 2:44 PM

wraitii mentioned this in rP23757: Handle stacking status effects, modifiers, some related fixes..Jun 9 2020, 1:48 PM

Changes (13)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

globalscripts/

AttackEffects.js

ModificationTemplates.js

Technologies.js

Templates.js

gui/

common/

tooltips.js

session/

selection_details.js

simulation/

components/

StatusEffectsReceiver.js

UnitAI.js

tests/

test_Damage.js

test_Pack.js

test_StatusEffectsReceiver.js

helpers/

Attacking.js

Transform.js

rP23448

View Options

ps/trunk/binaries/data/mods/public/globalscripts/AttackEffects.js

View Options

ps/trunk/binaries/data/mods/public/globalscripts/ModificationTemplates.js

View Options

ps/trunk/binaries/data/mods/public/globalscripts/Technologies.js

View Options

ps/trunk/binaries/data/mods/public/globalscripts/Templates.js

View Options

ps/trunk/binaries/data/mods/public/gui/common/tooltips.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/selection_details.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Damage.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Pack.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_StatusEffectsReceiver.js

View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Attacking.js

View Options

ps/trunk/binaries/data/mods/public/simulation/helpers/Transform.js

Allow status effect to apply modifiers and fix rP22901rP23448Actions

Description

Details

Event Timeline

Changes (13)

rP23448

ps/trunk/binaries/data/mods/public/globalscripts/AttackEffects.js

ps/trunk/binaries/data/mods/public/globalscripts/ModificationTemplates.js

ps/trunk/binaries/data/mods/public/globalscripts/Technologies.js

ps/trunk/binaries/data/mods/public/globalscripts/Templates.js

ps/trunk/binaries/data/mods/public/gui/common/tooltips.js

ps/trunk/binaries/data/mods/public/gui/session/selection_details.js

ps/trunk/binaries/data/mods/public/simulation/components/StatusEffectsReceiver.js

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Damage.js

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Pack.js

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_StatusEffectsReceiver.js

ps/trunk/binaries/data/mods/public/simulation/helpers/Attacking.js

ps/trunk/binaries/data/mods/public/simulation/helpers/Transform.js

Allow status effect to apply modifiers and fix rP22901
rP23448
Actions