Page MenuHomeWildfire Games

Internationalise damage types and status effects using (optional) JSON files
Needs ReviewPublic

Authored by wraitii on Sep 29 2019, 10:49 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Follows rP22527 and D2281 (which this requires).

This internationalises damage types and status effect names.
The system is similar to resources.json but the JSON files are not per-se required.
For damage types, they specify the order and the name but xml-only damage types are allowed for slightly easier modding.
For status effects, they act as 'augmenters' of template definitions, which means re-using the same status effect in several places is now much easier.

Test Plan

Check that the messages.json change is OK.

Check that the interface for the global scripts is considered acceptable.

Event Timeline

wraitii created this revision.Sep 29 2019, 10:49 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/866/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/350/display/redirect

There's a few bits of debug code I left which I'll clean up later.

binaries/data/mods/public/globalscripts/DamageTypes.js
33

I forgot here that I want damage types not in the data file to have lowest order, alphabetical.

binaries/data/mods/public/globalscripts/StatusEffects.js
40

needs to be nuked.

binaries/data/mods/public/gui/common/tooltips.js
533

Unrelated to these changes, but I noticed while testing Upgrade that this was required as we can have free upgrades and it fails.

binaries/data/mods/public/simulation/data/template_helpers/damage_types/pierce.json
5

description isn't actually used, should I nuke it?

wraitii updated this revision to Diff 10007.Sep 29 2019, 11:26 AM

Add the proper context, do the cleanup.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/867/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/351/display/redirect

This combines like 3 diffs?