HomeWildfire Games
Diffusion 0 A.D. Public Repository rP23906

Fixes the broken animation of the persian champion_cavalry_archer
rP23906
Actions

Description

Fixes the broken animation of the persian champion_cavalry_archer

Patch by: @Mr.lie

Differential Revision: https://code.wildfiregames.com/D2907

Details

Auditors
vladislavbelov
Committed
StanJul 28 2020, 10:23 PM
Differential Revision
D2907: Fixes the broken animation of the persian champion_cavalry_archer
Parents
rP23905: Split Audio and Map credits from Art.
Branches
Unknown
Tags
Unknown
Build Status
Buildable 12646
Build 24457: Post-Commit BuildJenkins
Build 24456: Post-Commit Build (macOS)Jenkins

Event Timeline

Stan committed rP23906: Fixes the broken animation of the persian champion_cavalry_archer.Jul 28 2020, 10:23 PM
Stan added an edge: D2907: Fixes the broken animation of the persian champion_cavalry_archer.
Stan added a subscriber: Mr.lie.
Harbormaster failed to build B12646: rP23906: Fixes the broken animation of the persian champion_cavalry_archer!Jul 28 2020, 10:27 PM
vladislavbelov raised a concern with this commit.Jul 30 2020, 3:59 AM
vladislavbelov added a subscriber: vladislavbelov.

Any change should be tested whenever possible.

/ps/trunk/binaries/data/mods/public/gui/credits/texts/art.json
80

Missed comma, generates JSON parsing error.

This commit now has outstanding concerns.Jul 30 2020, 3:59 AM
Stan mentioned this in rP23912: Fix missing coma in rP23906..Jul 30 2020, 8:08 AM
Stan requested verification of this commit.Jul 30 2020, 8:08 AM

Fixed in rP23912

This commit now requires verification by auditors.Jul 30 2020, 8:08 AM
vladislavbelov resigned from this commit.Jul 31 2020, 5:31 AM
This commit no longer requires audit.Jul 31 2020, 5:31 AM

Changes (11)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
art/
actors/
props/
units/
armor/
capes/
rider/
units/
persians/
gui/
credits/
texts/

rP23906

View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/armor/pers_neckguard_bronze.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/armor/pers_neckguard_iron.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/capes/rider/cape_long_beige.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/capes/rider/cape_long_boudicca.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/capes/rider/cape_long_gaul.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/capes/rider/cape_long_player.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/capes/rider/cape_med_hamilcar.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/capes/rider/cape_med_maharbal.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/props/units/capes/rider/cape_med_player.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/art/actors/units/persians/cavalry_archer_c_r.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/gui/credits/texts/art.json

Loading...
Wildfire Games ยท Phabricator