HomeWildfire Games
Diffusion 0 A.D. Public Repository rP24368

Fix zip with comments triggering assertion on game startup
rP24368
Actions

Description

Fix zip with comments triggering assertion on game startup
Fixes #5165

Patch by: @Teiresias

Differential Revision: https://code.wildfiregames.com/D1511

Details

Committed
StanDec 10 2020, 8:09 PM
Differential Revision
D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup)
Parents
rP24367: Fix userreport detection of sound cards
Branches
Unknown
Tags
Unknown
Build Status
Buildable 14287
Build 30085: Trigger Windows Autobuild
Build 30084: Post-Commit BuildJenkins
Build 30083: Post-Commit Build (macOS)Jenkins

Event Timeline

Stan committed rP24368: Fix zip with comments triggering assertion on game startup.Dec 10 2020, 8:09 PM
Stan added an edge: D1511: Patch to solve ticket #5165 (Zip files with comments trip assertion on game startup).
Stan added a subscriber: Teiresias.
Harbormaster completed building B14287: rP24368: Fix zip with comments triggering assertion on game startup.Dec 10 2020, 9:07 PM
vladislavbelov added a subscriber: vladislavbelov.Dec 13 2020, 3:39 PM
vladislavbelov added inline comments.
/ps/trunk/source/lib/file/archive/archive_zip.cpp
538

Wrong CC for casts here and below. Mismatch with the CC above.

/ps/trunk/source/lib/file/archive/tests/test_archive_zip.h
87

Wrong CC naming. Also you don't need to have these entities in the interface.

Changes (3)

PathSize
ps/
trunk/
source/
lib/
file/
archive/

rP24368

View Options

ps/trunk/source/lib/file/archive/archive_zip.cpp

Loading...
View Options

ps/trunk/source/lib/file/archive/tests/

Loading...
View Options

ps/trunk/source/lib/file/archive/tests/test_archive_zip.h

Loading...
Wildfire Games ยท Phabricator