Diffusion 0 A.D. Public Repository rP24487

Fix most Clang 10 Warnings
rP24487
Actions

Description

Fix most Clang 10 Warnings

Remove dead code from Phab:rP16704
Fix buggy code from Phab:rP15909
Comments by: @wraitii, @vladislavbelov

Differential Revision: https://code.wildfiregames.com/D3177

Details

Committed

Stan	Dec 31 2020, 3:25 PM

Differential Revision

D3177: Fix all reported warnings by Clang 10

Parents

rP24486: Fix AtlasUI committed by the CI, it seems something is still off there.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 14672
Build 31370: Trigger Windows Autobuild
Build 31369: Post-Commit Build	Jenkins
Build 31368: Post-Commit Build (macOS)	Jenkins

Event Timeline

Stan committed rP24487: Fix most Clang 10 Warnings.Dec 31 2020, 3:25 PM

Stan added an edge: D3177: Fix all reported warnings by Clang 10.

Stan added subscribers: vladislavbelov, wraitii.

Stan mentioned this in rP24488: Add missing files in Phab:rP24487.Dec 31 2020, 3:27 PM

Harbormaster completed building B14672: rP24487: Fix most Clang 10 Warnings.Dec 31 2020, 3:58 PM

Changes (15)

Path

Size

ps/

trunk/

source/

renderer/

ModelRenderer.cpp

PatchRData.cpp

simulation2/

components/

CCmpCinemaManager.cpp

CCmpPathfinder.cpp

CCmpRangeManager.cpp

CCmpTemplateManager.cpp

CCmpTerritoryManager.cpp

helpers/

HierarchicalPathfinder.cpp

soundmanager/

SoundManager.cpp

third_party/

jsonspirit/

json_spirit_value.h

tools/

atlas/

AtlasUI/

ScenarioEditor/

Sections/

Map/

Map.cpp

GameInterface/

Handlers/

rP24487

View Options

ps/trunk/source/renderer/ModelRenderer.cpp

View Options

ps/trunk/source/renderer/PatchRData.cpp

View Options

ps/trunk/source/simulation2/components/CCmpCinemaManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpPathfinder.cpp

View Options

ps/trunk/source/simulation2/components/CCmpRangeManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpTemplateManager.cpp

View Options

ps/trunk/source/simulation2/components/CCmpTerritoryManager.cpp

View Options

ps/trunk/source/simulation2/helpers/HierarchicalPathfinder.cpp

View Options

ps/trunk/source/soundmanager/SoundManager.cpp

View Options

ps/trunk/source/third_party/jsonspirit/json_spirit_value.h

View Options

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp

View Options

ps/trunk/source/tools/atlas/GameInterface/Handlers/CinemaHandler.cpp

View Options

ps/trunk/source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp

View Options

ps/trunk/source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp

View Options

ps/trunk/source/tools/atlas/GameInterface/View.cpp

Fix most Clang 10 WarningsrP24487Actions

Description

Details

Event Timeline

Changes (15)

rP24487

ps/trunk/source/renderer/ModelRenderer.cpp

ps/trunk/source/renderer/PatchRData.cpp

ps/trunk/source/simulation2/components/CCmpCinemaManager.cpp

ps/trunk/source/simulation2/components/CCmpPathfinder.cpp

ps/trunk/source/simulation2/components/CCmpRangeManager.cpp

ps/trunk/source/simulation2/components/CCmpTemplateManager.cpp

ps/trunk/source/simulation2/components/CCmpTerritoryManager.cpp

ps/trunk/source/simulation2/helpers/HierarchicalPathfinder.cpp

ps/trunk/source/soundmanager/SoundManager.cpp

ps/trunk/source/third_party/jsonspirit/json_spirit_value.h

ps/trunk/source/tools/atlas/AtlasUI/ScenarioEditor/Sections/Map/Map.cpp

ps/trunk/source/tools/atlas/GameInterface/Handlers/CinemaHandler.cpp

ps/trunk/source/tools/atlas/GameInterface/Handlers/MapHandlers.cpp

ps/trunk/source/tools/atlas/GameInterface/Handlers/ObjectHandlers.cpp

ps/trunk/source/tools/atlas/GameInterface/View.cpp

Fix most Clang 10 Warnings
rP24487
Actions