HomeWildfire Games

Fix hotkeys not releasing properly.
AuditedrP24645

Description

Fix hotkeys not releasing properly.

rP24215 changed hotkeys to use scancode, but didn't change g_keys to reflect that, and this could break hotkey release.
This fixes that by explicitly using scancodes. Note that we might want a g_keys map in the future, but it seems un-necessary at the moment.

Also remove the last remnants of 'negated' hotkeys, which were disabled following rP15980.

Tested By: OptimusShepard

Fixes #5922

Differential Revision: https://code.wildfiregames.com/D3379

Event Timeline

Silier raised a concern with this commit.Jan 16 2021, 4:44 PM
Silier added a subscriber: Silier.
Silier added inline comments.
/ps/trunk/source/gui/ObjectTypes/CInput.cpp
234

RCTRL

This commit now has outstanding concerns.Jan 16 2021, 4:44 PM
wraitii added inline comments.Jan 16 2021, 4:45 PM
/ps/trunk/source/ps/CConsole.cpp
363

Same here

382

here

396

here

wraitii requested verification of this commit.Jan 16 2021, 4:47 PM
This commit now requires verification by auditors.Jan 16 2021, 4:47 PM
Silier accepted this commit.Jan 16 2021, 4:50 PM
All concerns with this commit have now been addressed.Jan 16 2021, 4:50 PM

A new problem came up. I made a Ticket.
https://trac.wildfiregames.com/ticket/5930