Diffusion 0 A.D. Public Repository rP24983

Refactor all usage of RegisterFunction to ScriptFunction::Register
rP24983
Actions

Tags

None

Subscribers

Description

Refactor all usage of RegisterFunction to ScriptFunction::Register

Replace ScriptInterface::RegisterFunction with ScriptFunction::Register
- Mostly removing unused cmpPrivate*
- Some usage introduces specific getters (mapgenerator, AIWorker, XmppClient,...)
- Several passthrough functions are simply removed in favour of calling the original, reducing duplication
- Make use of ScriptRequest/ScriptInterface capabilities where relevant.
Make JSI_* headers only expose necessary functions, lightening them considerably and reducing duplication
- Reuse namespaces in JSI_* implementations directly, reducing visual noise there

Follows rP24969

Differential Revision: https://code.wildfiregames.com/D3626

Details

Auditors

Committed

Mar 2 2021, 9:01 PM

Differential Revision

D3626: Refactor all usage of RegisterFunction to ScriptFunction::Register

Parents

rP24982: Replace double division with multiplication/division

Branches

Unknown

Tags

Unknown

Build Status

Buildable 15943
Build 35419: Trigger Windows Autobuild
Build 35418: Post-Commit Build	Jenkins
Build 35417: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP24983: Refactor all usage of RegisterFunction to ScriptFunction::Register.Mar 2 2021, 9:01 PM

wraitii added an edge: D3626: Refactor all usage of RegisterFunction to ScriptFunction::Register.

Harbormaster completed building B15943: rP24983: Refactor all usage of RegisterFunction to ScriptFunction::Register.Mar 2 2021, 9:48 PM

wraitii mentioned this in rP24994: Fix NoPCH following rP24983.Mar 3 2021, 12:09 PM

A problem has been detected - #6373.

This commit now has outstanding concerns.Nov 1 2021, 9:53 PM

Langbart mentioned this in D4345: Fix for changeset 24983.Nov 12 2021, 2:09 AM

This commit no longer requires audit.Nov 20 2021, 4:05 PM

Changes (52)

Path

Size

ps/

trunk/

source/

graphics/

CameraController.cpp

MapGenerator.cpp

scripting/

JSInterface_GameView.cpp

JSInterface_GameView.h

gui/

Scripting/

JSInterface_GUIManager.cpp

JSInterface_GUIManager.h

ScriptFunctions.cpp

i18n/

scripting/

JSInterface_L10n.cpp

JSInterface_L10n.h

lobby/

scripting/

JSInterface_Lobby.cpp

JSInterface_Lobby.h

network/

scripting/

JSInterface_Network.cpp

JSInterface_Network.h

ps/

VisualReplay.cpp

scripting/

JSInterface_ConfigDB.cpp

JSInterface_ConfigDB.h

JSInterface_Console.cpp

JSInterface_Debug.cpp

JSInterface_Debug.h

JSInterface_Game.cpp

JSInterface_Game.h

JSInterface_Main.cpp

JSInterface_Main.h

JSInterface_ModIo.cpp

JSInterface_ModIo.h

JSInterface_SavedGame.cpp

JSInterface_SavedGame.h

JSInterface_UserReport.cpp

JSInterface_UserReport.h

JSInterface_VFS.cpp

JSInterface_VFS.h

JSInterface_VisualReplay.cpp

JSInterface_VisualReplay.h

renderer/

scripting/

JSInterface_Renderer.cpp

JSInterface_Renderer.h

scriptinterface/

NativeWrapperDecls.h

ScriptInterface.cpp

ScriptInterface.h

simulation2/

components/

CCmpAIManager.cpp

tests/

scripting/

JSInterface_Simulation.cpp

JSInterface_Simulation.h

soundmanager/

scripting/

JSInterface_Sound.cpp

JSInterface_Sound.h

rP24983

ps/trunk/source/graphics/CameraController.cpp

Loading...

ps/trunk/source/graphics/GameView.cpp

Loading...

ps/trunk/source/graphics/MapGenerator.cpp

Loading...

ps/trunk/source/graphics/MapGenerator.h

Loading...

ps/trunk/source/graphics/scripting/JSInterface_GameView.cpp

Loading...

ps/trunk/source/graphics/scripting/JSInterface_GameView.h

Loading...

ps/trunk/source/gui/Scripting/JSInterface_GUIManager.cpp

Loading...

ps/trunk/source/gui/Scripting/JSInterface_GUIManager.h

Loading...

ps/trunk/source/gui/Scripting/ScriptFunctions.cpp

Loading...

ps/trunk/source/i18n/scripting/JSInterface_L10n.cpp

Loading...

ps/trunk/source/i18n/scripting/JSInterface_L10n.h

Loading...

ps/trunk/source/lobby/IXmppClient.h

Loading...

ps/trunk/source/lobby/XmppClient.cpp

Loading...

ps/trunk/source/lobby/XmppClient.h

Loading...

ps/trunk/source/lobby/scripting/JSInterface_Lobby.cpp

Loading...

ps/trunk/source/lobby/scripting/JSInterface_Lobby.h

Loading...

ps/trunk/source/network/scripting/JSInterface_Network.cpp

Loading...

ps/trunk/source/network/scripting/JSInterface_Network.h

Loading...

ps/trunk/source/ps/ModIo.cpp

Loading...

ps/trunk/source/ps/ModIo.h

Loading...

ps/trunk/source/ps/VisualReplay.cpp

Loading...

ps/trunk/source/ps/VisualReplay.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_ConfigDB.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_Console.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_Debug.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_Debug.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_Game.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_Game.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_Main.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_Main.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_ModIo.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_ModIo.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_SavedGame.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_SavedGame.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_UserReport.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_UserReport.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_VFS.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_VFS.h

Loading...

ps/trunk/source/ps/scripting/JSInterface_VisualReplay.cpp

Loading...

ps/trunk/source/ps/scripting/JSInterface_VisualReplay.h

Loading...

ps/trunk/source/renderer/scripting/JSInterface_Renderer.cpp

Loading...

ps/trunk/source/renderer/scripting/JSInterface_Renderer.h

Loading...

ps/trunk/source/scriptinterface/NativeWrapperDecls.h

Loading...

ps/trunk/source/scriptinterface/ScriptInterface.cpp

Loading...

ps/trunk/source/scriptinterface/ScriptInterface.h

Loading...

ps/trunk/source/simulation2/components/CCmpAIManager.cpp

Loading...

ps/trunk/source/simulation2/components/tests/test_scripts.h

Loading...

ps/trunk/source/simulation2/scripting/JSInterface_Simulation.cpp

Loading...

ps/trunk/source/simulation2/scripting/JSInterface_Simulation.h

Loading...

ps/trunk/source/soundmanager/scripting/JSInterface_Sound.cpp

Loading...

ps/trunk/source/soundmanager/scripting/JSInterface_Sound.h

Loading...