HomeWildfire Games
Diffusion 0 A.D. Public Repository rP25133

Exclude Towers from Town->City phase requirements.
AuditedrP25133
Actions

Description

Exclude Towers from Town->City phase requirements.

Towers, unlike walls, palisades, and outposts, counted towards the required Town Phase structures for City Phase. Given the requirement to build 4 structures, this pushed players into making them.

This removes that, and lowers the requirement to 3.

Patch by: Nescio

Accepted By: ValihrAnt, borg-, wowgetoffyourcellphone, wraitii

Differential Revision: https://code.wildfiregames.com/D3686

Details

Auditors
Freagarach
Committed
wraitiiMar 26 2021, 6:21 PM
Differential Revision
D3686: [gameplay] exclude towers from phase requirements
Parents
rP25132: Unlock the Iberian monument in Town Phase
Branches
Unknown
Tags
Unknown
Build Status
Buildable 16421
Build 37038: Post-Commit BuildJenkins
Build 37037: Post-Commit Build (macOS)Jenkins

Event Timeline

wraitii committed rP25133: Exclude Towers from Town->City phase requirements..Mar 26 2021, 6:21 PM
wraitii added an edge: D3686: [gameplay] exclude towers from phase requirements.
Harbormaster completed building B16421: rP25133: Exclude Towers from Town->City phase requirements..Mar 26 2021, 7:30 PM
Freagarach raised a concern with this commit.Apr 20 2021, 11:07 AM
Freagarach added a subscriber: Freagarach.

PetraAI HQ needs an update.

This commit now has outstanding concerns.Apr 20 2021, 11:07 AM
Freagarach mentioned this in D4015: [PetraAI] - Fix city phase requirements in HQ..May 25 2021, 8:06 AM
Freagarach mentioned this in rP25564: Fix city phase requirements in PetraAI HQ..May 25 2021, 3:46 PM
Stan removed an auditor: Freagarach.Jun 7 2021, 2:02 PM
Stan added a subscriber: Stan.

Fixed now.

This commit no longer requires audit.Jun 7 2021, 2:02 PM
Freagarach raised a concern with this commit.Jul 28 2021, 7:04 AM

Concern that it may not be forgotten after the release.

/ps/trunk/binaries/data/mods/public/simulation/data/technologies/phase_city_athen.json
17

four != 3
-_-
https://wildfiregames.com/forum/topic/41264-alpha-25-pre-releaserelease-candidate-build-testing/?do=findComment&comment=444019

This commit now has outstanding concerns.Jul 28 2021, 7:04 AM
Freagarach added inline comments.Jul 28 2021, 7:24 PM
/ps/trunk/binaries/data/mods/public/simulation/data/technologies/phase_city_athen.json
17

(The -_- is because I feel ashamed for not noticing this in the game for several months.)

Silier mentioned this in D4202: Fix wrong number in tooltip for phase requirements .Jul 28 2021, 9:46 PM
Silier added a subscriber: Silier.
Silier added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/data/technologies/phase_city_athen.json
17

D4202

Silier mentioned this in rP25863: Fix wrong number in tooltip for phase requirements.Aug 27 2021, 8:41 PM
Freagarach accepted this commit.Sep 10 2021, 8:30 AM

My concern has been lifted.

All concerns with this commit have now been addressed.Sep 10 2021, 8:30 AM

Changes (7)

PathSize
ps/
trunk/
binaries/
data/
mods/
public/
simulation/
data/
technologies/
templates/

rP25133

View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/phase_city_athen.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/phase_city_generic.json

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_tower_artillery.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_tower_bolt.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_tower_sentry.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defensive_tower_stone.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_military_fortress.xml

Loading...
Wildfire Games ยท Phabricator