Diffusion 0 A.D. Public Repository rP26393

Remove useless persistMatchSettings and handle some which weren't handled
rP26393
Actions

Description

Remove useless persistMatchSettings and handle some which weren't handled

Fixing issues in rP25077

Everyone make sure to delete savegames, saved campaigns an most importantly your matchsettings.json's (regular alpha players won't notice since there is a version check, but if you already have your stuff at A26/svn, you will have some issues)

Reported By: elexis
Comments By: wraitii, Freagarach
Differential Revision: D4240

Details

Auditors

Langbart

Committed

bb	Feb 15 2022, 10:13 PM

Differential Revision

D4240: Remove useless persistMatchSettings and handle some which weren't handled

Parents

rP26392: Move parabolic range computation to rangemanager

Branches

Unknown

Tags

Unknown

Build Status

Buildable 19501
Build 46643: Post-Commit Build	Jenkins
Build 46642: Post-Commit Build (macOS)	Jenkins

Event Timeline

bb committed rP26393: Remove useless persistMatchSettings and handle some which weren't handled.Feb 15 2022, 10:13 PM

bb added an edge: D4240: Remove useless persistMatchSettings and handle some which weren't handled.

bb mentioned this in D4231: Generalise gamesettings pickRandomItems' loop.Feb 15 2022, 10:22 PM

Harbormaster completed building B19501: rP26393: Remove useless persistMatchSettings and handle some which weren't handled.Feb 15 2022, 10:31 PM

A problem has been detected #6433.

This commit now has outstanding concerns.Feb 16 2022, 9:44 AM

bb mentioned this in D4492: Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page..Feb 16 2022, 7:46 PM

bb mentioned this in D4498: Let StartingCamera react upon change in number of players.Feb 20 2022, 2:36 PM

Probably part of this patch: #6435

certainly

bb mentioned this in rP26464: Let StartingCamera react upon change in number of players.Feb 22 2022, 5:35 PM

D4492

This commit no longer requires audit.Mar 7 2022, 11:14 AM

Changes (25)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

autostart/

autostart.js

campaigns/

default_menu/

gamesettings/

attributes/

gamesetup/

Controllers/

GameSettingsController.js

loadgame/

loading/

replaymenu/

session/

lobby/

LobbyRatingReporter.js

summary/

summary.js

rP26393

View Options

ps/trunk/binaries/data/mods/public/gui/autostart/autostart.js

View Options

ps/trunk/binaries/data/mods/public/gui/campaigns/default_menu/CampaignMenu.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/GameSettings.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/CampaignData.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/Ceasefire.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/CircularMap.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/GameSpeed.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/MapName.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/MapPreview.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/MatchID.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/PlayerName.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/Rating.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/RegicideGarrison.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/SeaLevelRise.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/Seeds.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/StartingCamera.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/TeamPlacement.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/TriggerScripts.js

View Options

ps/trunk/binaries/data/mods/public/gui/gamesetup/Controllers/GameSettingsController.js

View Options

ps/trunk/binaries/data/mods/public/gui/loadgame/SavegameList.js

View Options

ps/trunk/binaries/data/mods/public/gui/loading/TitleDisplay.js

View Options

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_filters.js

View Options

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_menu.js

View Options

ps/trunk/binaries/data/mods/public/gui/session/lobby/LobbyRatingReporter.js

View Options

ps/trunk/binaries/data/mods/public/gui/summary/summary.js

Remove useless persistMatchSettings and handle some which weren't handledrP26393Actions

Description

Details

Event Timeline

Changes (25)

rP26393

ps/trunk/binaries/data/mods/public/gui/autostart/autostart.js

ps/trunk/binaries/data/mods/public/gui/campaigns/default_menu/CampaignMenu.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/GameSettings.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/CampaignData.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/Ceasefire.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/CircularMap.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/GameSpeed.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/MapName.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/MapPreview.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/MatchID.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/PlayerName.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/Rating.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/RegicideGarrison.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/SeaLevelRise.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/Seeds.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/StartingCamera.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/TeamPlacement.js

ps/trunk/binaries/data/mods/public/gui/gamesettings/attributes/TriggerScripts.js

ps/trunk/binaries/data/mods/public/gui/gamesetup/Controllers/GameSettingsController.js

ps/trunk/binaries/data/mods/public/gui/loadgame/SavegameList.js

ps/trunk/binaries/data/mods/public/gui/loading/TitleDisplay.js

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_filters.js

ps/trunk/binaries/data/mods/public/gui/replaymenu/replay_menu.js

ps/trunk/binaries/data/mods/public/gui/session/lobby/LobbyRatingReporter.js

ps/trunk/binaries/data/mods/public/gui/summary/summary.js

Remove useless persistMatchSettings and handle some which weren't handled
rP26393
Actions