Diffusion 0 A.D. Public Repository rP26476

Move FormationName and Icon from cmpFormation to cmpIdentity.
rP26476
Actions

Description

Move FormationName and Icon from cmpFormation to cmpIdentity.

Reduces duplication across components.
Allows to provide specific names and history for formations.

Differential revision: https://code.wildfiregames.com/D4476
Comments by: @bb, @Stan
Fixes #6400

Details

Committed

Freagarach

Feb 24 2022, 7:51 AM

Differential Revision

D4476: Move FormationName and Icon from cmpFormation to cmpIdentity.

Parents

rP26475: Fix building spidermonkey on systems with python 3.10

Branches

Unknown

Tags

Unknown

Build Status

Buildable 19624
Build 46954: Post-Commit Build	Jenkins
Build 46953: Post-Commit Build (macOS)	Jenkins

Event Timeline

Freagarach committed rP26476: Move FormationName and Icon from cmpFormation to cmpIdentity..Feb 24 2022, 7:51 AM

Freagarach added an edge: D4476: Move FormationName and Icon from cmpFormation to cmpIdentity..

Freagarach added subscribers: bb, Stan.

Harbormaster completed building B19624: rP26476: Move FormationName and Icon from cmpFormation to cmpIdentity..Feb 24 2022, 8:03 AM

Freagarach mentioned this in rP26756: Fix selecting formations when cycling through idle entities..Apr 3 2022, 7:38 PM

Changes (21)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

l10n/

messages.json

simulation/

components/

Formation.js

GuiInterface.js

tests/

test_UnitAI.js

templates/

special/

formations/

template_formation.xml

source/

tools/

entity/

checkrefs.py

rP26476

View Options

ps/trunk/binaries/data/mods/public/l10n/messages.json

View Options

ps/trunk/binaries/data/mods/public/simulation/components/Formation.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

View Options

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_UnitAI.js

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/anti_cavalry.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/battle_line.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/box.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/column_closed.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/column_open.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/flank.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/line_closed.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/line_open.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/null.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/phalanx.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/scatter.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/skirmish.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/testudo.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/wedge.xml

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_formation.xml

View Options

ps/trunk/source/tools/entity/checkrefs.py

Move FormationName and Icon from cmpFormation to cmpIdentity.rP26476Actions

Description

Details

Event Timeline

Changes (21)

rP26476

ps/trunk/binaries/data/mods/public/l10n/messages.json

ps/trunk/binaries/data/mods/public/simulation/components/Formation.js

ps/trunk/binaries/data/mods/public/simulation/components/GuiInterface.js

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_UnitAI.js

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/anti_cavalry.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/battle_line.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/box.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/column_closed.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/column_open.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/flank.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/line_closed.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/line_open.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/null.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/phalanx.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/scatter.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/skirmish.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/syntagma.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/testudo.xml

ps/trunk/binaries/data/mods/public/simulation/templates/special/formations/wedge.xml

ps/trunk/binaries/data/mods/public/simulation/templates/template_formation.xml

ps/trunk/source/tools/entity/checkrefs.py

Move FormationName and Icon from cmpFormation to cmpIdentity.
rP26476
Actions