Diffusion 0 A.D. Public Repository rP26627

[gameplay] Macedonian bonus - Instant storehouse technology research time.
rP26627
Actions

Description

[gameplay] Macedonian bonus - Instant storehouse technology research time.
Patch by: @ValihrAnt
Accepted by: @chrstgtr
Differential Revision: https://code.wildfiregames.com/D4234

Details

Committed

Stan	Mar 12 2022, 10:52 PM

Differential Revision

D4234: [gameplay] Macedonian bonus - Instant storehouse technology research time.

Parents

rP26626: [gameplay] Nerf Han hero Han Xin

Branches

Unknown

Tags

Unknown

Build Status

Buildable 19862
Build 47613: Post-Commit Build	Jenkins
Build 47612: Post-Commit Build (macOS)	Jenkins

Event Timeline

Stan committed rP26627: [gameplay] Macedonian bonus - Instant storehouse technology research time..Mar 12 2022, 10:52 PM

Stan added an edge: D4234: [gameplay] Macedonian bonus - Instant storehouse technology research time..

Stan added subscribers: chrstgtr, ValihrAnt.

Harbormaster completed building B19862: rP26627: [gameplay] Macedonian bonus - Instant storehouse technology research time..Mar 12 2022, 11:09 PM

I missed that the patch had to be rebased
https://code.wildfiregames.com/D4544

This commit now has outstanding concerns.Mar 13 2022, 10:54 AM

displaying the proper replaced value would require code changes irc.
So the option would be to change the time manually in each tech, or maybe just go with multiply: 0.1. Would still be near instant and properly displayed.

marder mentioned this in D4544: [Gameplay] Rebased Macedonian bonus.Mar 13 2022, 11:13 AM

rP26642

Fixed in rP26642

This commit no longer requires audit.Mar 25 2022, 9:24 PM

Changes (1)

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

data/

technologies/

civbonuses/

mace_storehouse.json

rP26627

View Options

ps/trunk/binaries/data/mods/public/simulation/data/technologies/civbonuses/mace_storehouse.json