Paths

Table of Contentst

Diffusion 0 A.D. Public Repository rP27928

Fix serialization test following rP27673 - Fix CalculateTerritories after…
rP27928
Actions

Description

Fix serialization test following rP27673 - Fix CalculateTerritories after deserialization

This fixes an issue revealed by rP27673 that affected deserialized games.
Adding tests further highlighted a bug in the calculations, which is fixed.

Reviewed By: phosit

Fixes #6883

Differential Revision: https://code.wildfiregames.com/D5181

Details

Committed

wraitii

Nov 11 2023, 11:34 AM

Reviewer

phosit

Differential Revision

D5181: Fix serialization test following rP27673 - Fix CalculateTerritories after deserialization

Parents

rP27927: [i18n] Updated POT and PO files.

Branches

Unknown

Tags

Unknown

Build Status

Buildable 22570
Build 55291: Trigger Windows Autobuild
Build 55290: Post-Commit Build	Jenkins
Build 55289: Post-Commit Build (macOS)	Jenkins

Event Timeline

wraitii committed rP27928: Fix serialization test following rP27673 - Fix CalculateTerritories after….Nov 11 2023, 11:34 AM

wraitii added an edge: D5181: Fix serialization test following rP27673 - Fix CalculateTerritories after deserialization.

Harbormaster completed building B22570: rP27928: Fix serialization test following rP27673 - Fix CalculateTerritories after….Nov 11 2023, 11:56 AM

vladislavbelov added a subscriber: vladislavbelov.Dec 2 2023, 11:55 PM

vladislavbelov added inline comments.

/ps/trunk/source/simulation2/components/tests/test_TerritoryManager.h
38–65	`virtual` shouldn't present if there is `override`.
68	Incorrect naming, `Mgr` and `Man` for the same word, also might be full words.

Changes (2)

Path

Size

ps/

trunk/

source/

simulation2/

components/

CCmpTerritoryManager.cpp

tests/

test_TerritoryManager.h

rP27928

View Options

ps/trunk/source/simulation2/components/CCmpTerritoryManager.cpp