Paths

Table of Contentst

Differential D1051

Unify Gamesetup/Lobby Chat Design
ClosedPublic
Actions

Authored by ffffffff on Nov 21 2017, 12:12 PM.

Tags

None

Subscribers

Restricted Owners Package

Details

Reviewers

Commits

rP21003: Unify Gamesetup/Lobby Chat Design

Trac Tickets

Summary

Adding send button to lobby like in multiplayer gamesetup.

Also making size and proporations for chat input same.

Especially when in fullscreen keep the middle panel to the button of the window, so minor changes in the relatives size, to make it like 100%-20.

Before it was little floating upward when higher resolution of the window.

Before relative size of middle panel

and after:

Whole:

Changing font for time (from bold to not bold) like in gamesetup chat:

Making buttons in lobby tighter together

Test Plan

test

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ffffffff created this revision.Nov 21 2017, 12:12 PM

ffffffff edited the summary of this revision. (Show Details)

ffffffff edited the summary of this revision. (Show Details)

ffffffff edited the summary of this revision. (Show Details)Nov 21 2017, 12:14 PM

ffffffff updated this revision to Diff 4300.Nov 21 2017, 12:17 PM

ffffffff edited the summary of this revision. (Show Details)Nov 21 2017, 12:21 PM

ffffffff edited the summary of this revision. (Show Details)Nov 21 2017, 12:25 PM

ffffffff edited the summary of this revision. (Show Details)

ffffffff added a subscriber: Hannibal_Barca.

20 pixel for chatInput seems not fitting previous height.

so setting it to 22 pixel fix like previous height.

Looks like a good idea

In D1051#41544, @ffffffff wrote:

20 pixel for chatInput seems not fitting previous height.

so setting it to 22 pixel fix like previous height.

Don't understand that comment. Why shoudn't it fit for 20px?
Else it is good to go.

binaries/data/mods/public/gui/lobby/lobby.js
1415 ↗	(On Diff #4302)	As that is the default font, why not just remove the font tag?

This revision now requires changes to proceed.Nov 26 2017, 4:23 PM

statings from @Imarok

absolutly correct

In D1051#42521, @Imarok wrote:

In D1051#41544, @ffffffff wrote:

20 pixel for chatInput seems not fitting previous height.

so setting it to 22 pixel fix like previous height.

Don't understand that comment. Why shoudn't it fit for 20px?

20px is the relative distance from 100% same as the other left and right panel objects in lobby so unify here and bring them on the same bottom level.
also fixing chat input to 22px same as gamesetup, so the font is fitting good in especialy letters like "y", so they dont touch bottom or top.

Also the size at top from middle panel in lobby was before only relative at 5% so at bigger resolutions there is big gap to the header. Just unify here also to a fixed value - like left and right panel - 38px which is nearly same as in default 1024x768 5%.

binaries/data/mods/public/gui/lobby/lobby.js
1415 ↗	(On Diff #4302)	true

Imarok added inline comments.Dec 1 2017, 3:27 PM

binaries/data/mods/public/gui/lobby/lobby_panels.xml
174 ↗	(On Diff #4469)	What about setting left and right panel also to 38? Then left, middle and right panel would be aligned.

ffffffff added inline comments.Dec 4 2017, 6:44 PM

binaries/data/mods/public/gui/lobby/lobby_panels.xml
174 ↗	(On Diff #4469)	i tried seem to much gap (as there is no window caption button above)

Imarok added inline comments.Dec 5 2017, 9:43 PM

binaries/data/mods/public/gui/lobby/lobby_panels.xml
174 ↗	(On Diff #4469)	hmm, to me that seems to be much cleaner (See https://imgur.com/a/vt62j for comparing)

ffffffff added inline comments.Dec 5 2017, 10:08 PM

binaries/data/mods/public/gui/lobby/lobby_panels.xml
174 ↗	(On Diff #4469)	Cleaner but we loosing space :( (especialy in 1024x768) What does @elexis spexis says?

Comparison

left right panel starts normal 30 gap to top

left right panel + middle panel starts all 38 gap to top (clean)

(lazy)

In D1051#44622, @elexis wrote:

(lazy)

ok

ffffffff edited the summary of this revision. (Show Details)Dec 6 2017, 5:23 PM

ffffffff removed subscribers: Imarok, Hannibal_Barca, bb.

ffffffff edited the summary of this revision. (Show Details)Dec 6 2017, 5:27 PM

ok im thinking u r right @Imarok lets take cleaner one 38px

and as we are doing so how do like having buttons little tightend for a cleaner interface? (its small just little cosmetic)

before

after

as there are no strong opinion what i heard we may also want apply D893.

tighten buttons

In D1051#44840, @ffffffff wrote:

as there are no strong opinion what i heard we may also want apply D893.

can be also to much maybe we should wait about D1063 to finish

ffffffff updated the Trac tickets for this revision.Jan 18 2018, 7:06 AM

ffffffff removed a reviewer: elexis.

Looks good.
Rebase it and I'll commit it.

This revision now requires changes to proceed.Jan 20 2018, 12:23 PM

elexis added a subscriber: elexis.Jan 20 2018, 2:16 PM

elexis added inline comments.

binaries/data/mods/public/gui/page_lobby.xml
9 ↗	(On Diff #4629)	Make sure its needed

rebase auf r20964

gamesetup hochgezogen auf 40 replay menu auch

anpassung des lobby overlay dialogs im init von lobby.js

Looks good

This revision is now accepted and ready to land.Jan 23 2018, 5:55 PM

Imarok added inline comments.Jan 24 2018, 3:54 PM

binaries/data/mods/public/gui/lobby/lobby.js
461 ↗	(On Diff #5423)	trailing whitespace

Closed by commit rP21003: Unify Gamesetup/Lobby Chat Design (authored by Imarok). · Explain WhyJan 24 2018, 3:55 PM

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Jan 24 2018, 3:55 PM

elexis added inline comments.Jan 28 2018, 4:23 PM

ps/trunk/binaries/data/mods/public/gui/page_lobby.xml
9	It's needed for the `StoneButton`, thanks for the answer. And no, we should not add this to a page that uses red buttons everywhere

elexis mentioned this in rP23172: Rewrite lobby page to use class semantics, add more gamedetails labels, improve….Nov 21 2019, 2:45 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

gamesetup/

26 lines

lobby/

10 lines

lobby_panels.xml

26 lines

1 line

Diff 5473

ps/trunk/binaries/data/mods/public/gui/gamesetup/gamesetup.xml

Loading...

ps/trunk/binaries/data/mods/public/gui/lobby/lobby.js

Loading...

ps/trunk/binaries/data/mods/public/gui/lobby/lobby_panels.xml

Loading...

ps/trunk/binaries/data/mods/public/gui/page_lobby.xml

Loading...