Details
Details
- Reviewers
s0600204 - Commits
- rP20504: Pass the size in meters of a terrain grid tile from Terrain.h to the rmgen JS…
- Trac Tickets
- #4034
cpp part doesn't look like it could use a const, does it? warn(TERRAIN_TILE_SIZE);.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Updating workspaces... Build (release)... Build (debug)... Running release tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (307 tests)...................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
Comment Actions
Looks good, and works as expected, thank you.
binaries/data/mods/public/maps/random/rmgen/library.js | ||
---|---|---|
18 ↗ | (On Diff #4343) | g_TerrainTileSize? (If you're wanting globals to have a g_Foo style) |
Comment Actions
Thanks for the review.
binaries/data/mods/public/maps/random/rmgen/library.js | ||
---|---|---|
18 ↗ | (On Diff #4343) | If it was GUI code I would certainly agree. In rP20437 I have even used Elevation_ExcludeMin_IncludeMax. In this case it would be the first engine constant that would not use upper case. I believe those constants won't be used that often and the case could be changed afterwards without too much hassle. At least. |