Page MenuHomeWildfire Games
Differential D1125

Adds test in ProductionQueue for the {civ} tech replacement from rP20551
ClosedPublic
Actions

Authored by mimo on Dec 7 2017, 7:49 PM.

Details

Reviewers
elexis
Commits
rP20604: Adds test in ProductionQueue for the {civ} tech replacement from rP20551
Summary

Complete the tests in ProductionQueue introduced in rP20603 to also cover the tech replacement from rP20551

Test Plan

Check that the tests run

Diff Detail

Event Timeline

mimo created this revision.Dec 7 2017, 7:49 PM
elexis accepted this revision.Dec 7 2017, 8:03 PM
elexis added a subscriber: elexis.

Test succeeds.
A testcase where one can train templates of two different civs might catch some edge case if one wants to add more coverage.

binaries/data/mods/public/simulation/components/tests/test_ProductionQueue.js
16

classic

21

(I meant one template per line, so that all start with units/ at the same location)

78

I guess one of the reviewers could have been more skeptical

118
foo(
     bar,
     [x1, x2]);

or

foo(
   bar
   [
        x1,
        x2
   ]);

or
not

131

(Someone could have used arrays or Sets when introducing the thing)

This revision is now accepted and ready to land.Dec 7 2017, 8:03 PM
Vulcan added a subscriber: Vulcan.Dec 7 2017, 8:27 PM

Build failure - The Moirai have given mortals hearts that can endure.

Harbormaster failed remote builds in B3998: Diff 4633!Dec 7 2017, 8:27 PM
Vulcan added a comment.Dec 7 2017, 8:28 PM
Executing section Default...
Executing section Source...
Executing section JS...
Closed by commit rP20604: Adds test in ProductionQueue for the {civ} tech replacement from rP20551 (authored by mimo). · Explain WhyDec 7 2017, 10:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
binaries/
data/
mods/
public/
simulation/
components/
tests/
70 lines

Diff 4633

View Options

binaries/data/mods/public/simulation/components/tests/test_ProductionQueue.js

Loading...
Wildfire Games · Phabricator