Page MenuHomeWildfire Games

sandbox map preview naming consistency
Needs RevisionPublic

Authored by Nescio on Dec 28 2018, 2:53 PM.

Details

Reviewers
Itms
Summary

Each civilization has a sandbox scenario, which are named Sandbox - {Civ}. However, the names of their mappreviews are not always obvious (e.g. sandbox-themacks.png); this proposal applies the sandbox_kushites.png naming scheme to the others for consistency.

Test Plan

Ought to be unproblematic

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6542
Build 10815: Vulcan BuildJenkins
Build 10814: arc lint + arc unit

Event Timeline

Nescio created this revision.Dec 28 2018, 2:53 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Dec 28 2018, 2:53 PM
Vulcan added a subscriber: Vulcan.Dec 28 2018, 4:37 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/839/

Itms requested changes to this revision.Jan 2 2019, 4:14 PM

This now needs a rebase after rP22005, sorry for that (I thought it would be better to plainly change mauryans to mauryas everywhere, to avoid mistakes as much as possible).

I cannot find the discussion again... but we had discussed the fact that map file names should be without spaces as much as possible. We couldn't reach an agreement on how to write the number of players in skirmishes (currently with (2) and the likes), but for this diff, I think it would be a no-brainer to rename the maps as sandbox_iberians.xml/pmp, following the same convention as chosen for the png files.

This revision now requires changes to proceed.Jan 2 2019, 4:14 PM

D1042 is about renaming map files (the spaces and special characters in file names are still problematic). This one is about the (new?) map preview names (art/), so it's related but separate.