Page MenuHomeWildfire Games
Differential D1733

Rename wallset template
ClosedPublic
Actions

Authored by Nescio on Jan 5 2019, 10:16 PM.

Details

Reviewers
bb
Commits
rP22116: Nuke the misleading Structure_Defence from the wallset template name
Summary

Moves template_structure_defense_wallset.xml to template_wallset.xml, because this template has no parent, therefore its current name is misleading.

Test Plan

Ought to be unproblematic.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6734
Build 11075: Vulcan BuildJenkins
Build 11074: arc lint + arc unit

Event Timeline

Nescio created this revision.Jan 5 2019, 10:16 PM
Vulcan added a subscriber: Vulcan.Jan 5 2019, 10:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/929/

Harbormaster completed remote builds in B6734: Diff 7282.Jan 5 2019, 10:27 PM
bb accepted this revision.Jan 5 2019, 11:01 PM
bb added a subscriber: bb.

grepped for completeness, agreeing on the change, translators will hate
(note to self: be careful with file move)

This revision is now accepted and ready to land.Jan 5 2019, 11:01 PM
Nescio added a comment.Jan 26 2019, 1:14 PM

Still good? rP22070

Stan added a comment.Jan 26 2019, 1:17 PM

If you only move the file should be fine.

Nescio added a comment.Jan 26 2019, 1:20 PM

That's good to know, thanks!

Nescio mentioned this in D1787: rename template_unit_fauna_decorative to template_bird.Mar 16 2019, 9:56 PM
Closed by commit rP22116: Nuke the misleading Structure_Defence from the wallset template name (authored by bb). · Explain WhyMar 16 2019, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7282

View Options

binaries/data/mods/public/simulation/templates/other/wallset_palisade.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/athen_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/brit_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/cart_wallset_short.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/cart_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/gaul_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/iber_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/kush_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/mace_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/maur_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/pers_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/ptol_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/rome_wallset_siege.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/rome_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/sele_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/structures/spart_wallset_stone.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_structure_defense_wallset.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_wallset.xml

Loading...
Wildfire Games · Phabricator