Heroes cost increased, highlighting their role as unique unit with unique effects.
Templates components inheritance is highlighted too.
mauryan Chanakya parent template changed
Details
Details
Heroes cost increased, highlighting their role as unique unit with unique effects.
Templates components inheritance is highlighted too.
mauryan Chanakya parent template changed
Training heroes will be more expensive in order to properly represent their influence on the game.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/638/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/639/ for more details.
Comment Actions
Not introduced by the patch, but while at cleaning, let's actually clean. If I want to know the cost of a hero infantry pikeman, I have to check 3 templates:
<Resources> <food>200</food> <metal>250</metal> </Resources>
Then
<Resources> <metal>200</metal> </Resources>
And
<Resources> <wood>50</wood> </Resources>
To get F200 W50 M200
Also strangely for the spearman the last step is
<Resources> <wood op="add">50</wood> </Resources>
Also check inheritance of that mauryan healer hero. I pointed out one to be explicit. Find the others.
| binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml | ||
|---|---|---|
| 27 ↗ | (On Diff #1005) | Already asked to change/check that |
Comment Actions
Watching at Children templates is easier than the previous diff.
I still think that distinguishing the cost of units sharing the same parent template is needed to understand the reason of such resource.
more Chanakya redundanced are now nuked.
| binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml | ||
|---|---|---|
| 30–31 ↗ | (On Diff #1020) | check it too |
Comment Actions
Build has FAILED
Link to build: http://jw:8080/job/phabricator/649/
See console output for more information: http://jw:8080/job/phabricator/649/console
| binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml | ||
|---|---|---|
| 30–31 ↗ | (On Diff #1020) | the entry above |
| binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml | ||
|---|---|---|
| 18 ↗ | (On Diff #1050) | Try again? |
| binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml | ||
|---|---|---|
| 18 ↗ | (On Diff #1087) | While at it consider if Soldier classe should be in the parent template or add for cavalry and infantry one (and elephant - needs to check that: see first what is done for champs). |
| 28 ↗ | (On Diff #1087) | perhaps just keep the parent one which is not really different or just change that parent one as it's mainly overwriten by all/ most of its childs. |
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/687/ for more details.
Comment Actions
You should specify in the summary that you add a capture attack for the healer hero and check that there is not conflict in the code between that and its support class (which would be interesting).
| binaries/data/mods/public/simulation/templates/template_unit_hero.xml | ||
|---|---|---|
| 22 ↗ | (On Diff #1087) | If you don't use relative templates in child templates. Imo that part can be nuke (and moved for the healer hero) |
| binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml | ||
| 8 ↗ | (On Diff #1087) | Not checked |
Comment Actions
template_unit_hero: removed the UnitMotion entry and added to the missing children.
removed the Cost entry.
Chanakya: removed the garrison_hero aura since it is inherited.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/693/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/784/ for more details.
Comment Actions
I made some tables.
Currently champ policy is
- infantry 125f 100w 75m
- cavalry 250f 100w 100m
- +25w -25m for swordmen.
Basically we take here the same policy but x2. It fixes the current big inconsistency.
Other changes:
Training time.
Repeat attack of swordmen made consistent with the related champ.
Armor is keeped as it is now but use relative template. No clue if it should be in the scope of that patch. Imo don't do that here.
Request changes:
- inlined comments
- also +10 training time for elephant hero
| binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry.xml | ||
|---|---|---|
| 8 ↗ | (On Diff #1275) | add 10 build time |
| 10 ↗ | (On Diff #1275) | 500 food but seems too much. 400 food sounds ok |
| 11 ↗ | (On Diff #1275) | 200 wood |
| binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_archer.xml | ||
| 21 ↗ | (On Diff #1275) | nuke |
| binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_javelinist.xml | ||
| 21 ↗ | (On Diff #1275) | nuke |
| binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_spearman.xml | ||
| 21 ↗ | (On Diff #1275) | nuke |
| binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_swordsman.xml | ||
| 21 ↗ | (On Diff #1275) | -50 wood |
| binaries/data/mods/public/simulation/templates/template_unit_hero_infantry.xml | ||
| 11 ↗ | (On Diff #1275) | 200 wood |
| binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_archer.xml | ||
| 20–21 ↗ | (On Diff #1275) | nuke |
| binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_javelinist.xml | ||
| 21 ↗ | (On Diff #1275) | nuke |
| binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_pikeman.xml | ||
| 27 ↗ | (On Diff #1275) | nuke |
| binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_spearman.xml | ||
| 27 ↗ | (On Diff #1275) | nuke |
| binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml | ||
| 21 ↗ | (On Diff #1275) | -50 wood |
| binaries/data/mods/public/simulation/templates/template_unit_hero_infantry.xml | ||
|---|---|---|
| 40 ↗ | (On Diff #1275) | No need imo |
Comment Actions
patch updated in order to reflect recent commits.
Costs retweaked in order to properly scale as fatherbushido pointed out.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1375/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Checking XML files...
http://jw:8080/job/phabricator/1381/ for more details.
Comment Actions
Fine. The healer hero needs to be rebased but I'll do it when commiting.
The change make consistent hero cost with champion cost and hero cost between them. The policy is mainly 2x champ cost exepting for some values.
Armour uses relative templates and are not changed.
| binaries/data/mods/public/simulation/templates/units/maur_hero_chanakya.xml | ||
|---|---|---|
| 56 ↗ | (On Diff #2246) | Not at the wrong place :p |
| ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_cavalry_swordsman.xml | ||
|---|---|---|
| 14 | (likewise) | |
| 21 | Why add the inconsistency if the rest was about removing inconsistencies in the cost? | |
| ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_spearman.xml | ||
| 14 | D186 -> ack | |
| ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml | ||
| 14 | Weren't they strong enough? PrepareTime could be set to 350 if it's about making it equal to template_unit_champion_infantry_swordsman. They now deal 33% more damage in the same time (hack attack could be reduced) | |
| 20 | why not op="add" -50? | |
| ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml | ||
|---|---|---|
| 14 | Can I revert that +33% attack damage per second for sword heroes (by reducing their Hack attack proportionally) or was that quite big buff needed for anything? | |
| ps/trunk/binaries/data/mods/public/simulation/templates/template_unit_hero_infantry_swordsman.xml | ||
|---|---|---|
| 14 | We have now just an hero with 2x attack stat compares to the mathcing champ. So in fact, now it's consistent, and before they were a little above the other hero (if we think in champ - hero constistency). | |
| 20 | What do you say Grugnas? You use it below. | |
| 20 | Or you mean with the "-"? | |