Page MenuHomeWildfire Games

Combine attacker data in "attackerData" in attack-related code.
Needs ReviewPublic

Authored by Freagarach on Sep 8 2019, 2:56 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This combines the data of an attack (owner, attacker ID) in a attackerData node. This would allow adding more data more easily in the future. E.g. the position from where the attack occured for attack bonus or for throwback.
Split from D781.

Test Plan

Verify that attacks, still behave the same, bonuses are still applied and no code is forgotten to be changed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
SeverityLocationCodeMessage
Warningbinaries/data/mods/public/simulation/components/Capturable.js:22ESLintBear (spaced-comment)ESLintBear (spaced-comment)
Warningbinaries/data/mods/public/simulation/components/Capturable.js:161ESLintBear (spaced-comment)ESLintBear (spaced-comment)
Warningbinaries/data/mods/public/simulation/components/Capturable.js:303ESLintBear (spaced-comment)ESLintBear (spaced-comment)
Unit
No Unit Test Coverage
Build Status
Buildable 12861
Build 25192: Vulcan BuildJenkins
Build 25191: Vulcan Build (macOS)Jenkins
Build 25190: Vulcan Build (Windows)Jenkins
Build 25189: arc lint + arc unit

Event Timeline

Freagarach created this revision.Sep 8 2019, 2:56 PM
Vulcan added a comment.Sep 8 2019, 2:58 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/608/display/redirect

Vulcan added a comment.Sep 8 2019, 2:58 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/99/display/redirect

Freagarach updated this revision to Diff 9673.Sep 9 2019, 9:43 AM

Always not nice when your test passes, you apply a last-minute-change and forget to test that...

Vulcan added a comment.Sep 9 2019, 9:47 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/103/display/redirect

Vulcan added a comment.Sep 9 2019, 9:57 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/612/display/redirect

Freagarach updated this revision to Diff 10432.Nov 28 2019, 9:39 AM
Freagarach edited the summary of this revision. (Show Details)
Freagarach edited the test plan for this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/656/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1172/display/redirect

Freagarach updated this revision to Diff 13175.Aug 11 2020, 8:03 PM
  • Rebased.