- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
- rP23927: Fix text input max_length attribute. fixes rP15785
Check any text fuzzing you now to make sure one cannot enter more than X characters in the fields with a max_length attribute.
Original patch was made by Amplikon, but has been mostly rewritten.
To answer smiley's comments,
int is used everywhere else except in one place where it uses long for some reason.
Yep, because in this case if the function expect a return type, which was not easily visible without context.
Since apparently I had commented on this before, I have a feeling this would not quite work the way it should in certain cases.
Then again, its just a feeling. Consider that before wasting hours on potentially nothing.
Thanks for the fair warning, and the time you took to express it :)
Actually, no. That was a snarky at best, counter productive at worst warning.
Regardless, your refactor fixed that bug.