Details

Reviewers

wraitii

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP23927: Fix text input max_length attribute. fixes rP15785

Summary

See #5266 caused by rP15785

Test Plan

Check any text fuzzing you now to make sure one cannot enter more than X characters in the fields with a max_length attribute.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12702
Build 24640: Vulcan Build	Jenkins
Build 24639: Vulcan Build (macOS)	Jenkins
Build 24638: Vulcan Build (Windows)	Jenkins
Build 24637: arc lint + arc unit

Event Timeline

Stan created this revision.Oct 15 2019, 3:10 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/974/display/redirect

Harbormaster failed remote builds in B9819: Diff 10160!Oct 15 2019, 3:11 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/459/display/redirect

Original patch was made by Amplikon, but has been mostly rewritten.

To answer smiley's comments,

In #5266, @smiley wrote:

Use static_cast<int> instead of (int).

Done.

In #5266, @smiley wrote:

Unsigned integer probably.

int is used everywhere else except in one place where it uses long for some reason.

In #5266, @smiley wrote:

Sure it should not be a break;? (Same thing is in L308, Plus, from a quick skim, break; makes more sense to me. Could be wrong of course.)

Yep, because in this case if the function expect a return type, which was not easily visible without context.

Stan added a subscriber: lyv.Oct 15 2019, 3:18 PM

Stan removed a subscriber: lyv.

Since apparently I had commented on this before, I have a feeling this would not quite work the way it should in certain cases.

Then again, its just a feeling. Consider that before wasting hours on potentially nothing.

In D2377#99209, @smiley wrote:

Since apparently I had commented on this before, I have a feeling this would not quite work the way it should in certain cases.

Then again, its just a feeling. Consider that before wasting hours on potentially nothing.

Thanks for the fair warning, and the time you took to express it :)

This should be updated.

Rebase.
Fix logic.
Add support for max length with paste
Remove casts.

The default case l324 seems useless but I'm not sure. I have not been able to enter it

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2789/display/redirect

Harbormaster failed remote builds in B12633: Diff 12936!Jul 27 2020, 12:49 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/1157/display/redirect

Fix Unix* builds

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2829/display/redirect

Harbormaster completed remote builds in B12684: Diff 12991.Aug 1 2020, 3:13 PM

Thanks for the fair warning, and the time you took to express it :)

Actually, no. That was a snarky at best, counter productive at worst warning.

Regardless, your refactor fixed that bug.

You're missing the case where the user-autocompletes a pseudo, or any JS modifying "caption" in fact. You probably need to add a final check in UpdateText() or in HandleMessage.

Otherwise seems to work.

See D2629 for a bug where text-too-long crashes.

This revision now requires changes to proceed.Aug 1 2020, 5:18 PM

Broken attempt @wraitii can you help me

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2832/display/redirect

Harbormaster completed remote builds in B12688: Diff 12995.Aug 1 2020, 6:22 PM

Fix curpos

Don't crop non maxlength inputs

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2842/display/redirect

Successful build - Chance fights ever on the side of the prudent.