Page MenuHomeWildfire Games
Differential D240

Unit tests for JS Pack component
ClosedPublic
Actions

Authored by fatherbushido on Mar 20 2017, 10:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 12:07 PM
Unknown Object (File)
Aug 27 2024, 5:38 AM
Unknown Object (File)
Aug 18 2024, 9:07 AM
Unknown Object (File)
May 1 2017, 2:03 PM
Unknown Object (File)
Apr 19 2017, 3:10 PM
Unknown Object (File)
Apr 19 2017, 4:09 AM
Unknown Object (File)
Apr 18 2017, 12:27 AM
Unknown Object (File)
Apr 18 2017, 12:04 AM
View All 15 Files
Subscribers
Sandarac
Vulcan
Restricted Owners Package
Restricted Owners Package
Restricted Owners Package

Details

Reviewers
wraitii
Itms
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP19350: Unit tests for JS Pack component
Summary

Unit tests.

Test Plan

Irrelevant.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 834
Build 1314: Vulcan BuildJenkins
Build 1313: arc lint + arc unit

Event Timeline

fatherbushido created this revision.Mar 20 2017, 10:16 PM
Vulcan added a subscriber: Vulcan.Mar 20 2017, 11:01 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/557/ for more details.

Harbormaster completed remote builds in B821: Diff 870.Mar 20 2017, 11:01 PM
Sandarac added a subscriber: Sandarac.Mar 21 2017, 8:29 AM

I just noticed a few missing semicolons.

binaries/data/mods/public/simulation/components/tests/test_Pack.js
81

Missing semicolon.

84

Missing semicolon.

106

Missing semicolon.

114

Missing semicolon.

117

Missing semicolon.

fatherbushido added a comment.Mar 21 2017, 10:06 AM

Thanks!

fatherbushido updated this revision to Diff 874.Mar 21 2017, 2:34 PM

Missing semicolon noticed by Sandarac

Vulcan added a comment.Mar 21 2017, 3:20 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/559/ for more details.

Harbormaster completed remote builds in B825: Diff 874.Mar 21 2017, 3:20 PM
fatherbushido updated this revision to Diff 885.Mar 22 2017, 1:27 PM

Actually test unpack completion.

Harbormaster completed remote builds in B833: Diff 885.Mar 22 2017, 1:27 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package, Restricted Owners Package.Mar 22 2017, 1:27 PM
Vulcan added a comment.Mar 22 2017, 2:12 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/566/ for more details.

Harbormaster completed remote builds in B833: Diff 885.Mar 22 2017, 2:13 PM
fatherbushido updated this revision to Diff 886.Mar 22 2017, 2:55 PM

eol-style=native

fatherbushido updated this revision to Diff 887.Mar 22 2017, 3:07 PM

Remove unrelated files

Vulcan added a comment.Mar 22 2017, 3:40 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/567/ for more details.

Harbormaster completed remote builds in B834: Diff 886.Mar 22 2017, 3:40 PM
Vulcan added a comment.Mar 22 2017, 4:25 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/568/ for more details.

Harbormaster completed remote builds in B835: Diff 887.Mar 22 2017, 4:25 PM
fatherbushido added a reviewer: wraitii.Mar 25 2017, 9:46 AM
fatherbushido updated this revision to Diff 966.Mar 27 2017, 1:28 PM

Explain the 250 const as suggested by wraitii

wraitii accepted this revision.Mar 27 2017, 1:32 PM
This revision is now accepted and ready to land.Mar 27 2017, 1:32 PM
fatherbushido updated this revision to Diff 967.Mar 27 2017, 1:38 PM

Add native eol-style property

Vulcan added a comment.Mar 27 2017, 2:14 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/615/ for more details.

Harbormaster completed remote builds in B908: Diff 966.Mar 27 2017, 2:14 PM
Closed by commit rP19350: Unit tests for JS Pack component (authored by fatherbushido). · Explain WhyMar 27 2017, 2:41 PM
This revision was automatically updated to reflect the committed changes.
Vulcan added a comment.Mar 27 2017, 3:01 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/616/ for more details.

Harbormaster completed remote builds in B909: Diff 967.Mar 27 2017, 3:01 PM

Revision Contents
Changeset List

Diff 886

View Options

binaries/data/mods/public/gui/session/session.js

Loading...
View Options

binaries/data/mods/public/gui/summary/counters.js

Loading...
View Options

binaries/data/mods/public/maps/random/survivalofthefittest_triggers.js

Loading...
View Options

binaries/data/mods/public/simulation/ai/petra/attackPlan.js

Loading...
View Options

binaries/data/mods/public/simulation/ai/petra/baseManager.js

Loading...
View Options

binaries/data/mods/public/simulation/components/Identity.js

Loading...
View Options

binaries/data/mods/public/simulation/components/StatisticsTracker.js

Loading...
View Options

binaries/data/mods/public/simulation/components/TechnologyManager.js

Loading...
View Options

binaries/data/mods/public/simulation/components/TrainingRestrictions.js

Loading...
View Options

binaries/data/mods/public/simulation/components/tests/test_Pack.js

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_structure_wonder.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_unit_mechanical_ship_bireme.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_unit_mechanical_ship_fishing.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_unit_mechanical_ship_merchant.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_unit_mechanical_ship_quinquereme.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_unit_mechanical_ship_trireme.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/template_unit_support_female_citizen.xml

Loading...
View Options

binaries/data/mods/public/simulation/templates/units/brit_hero_boudicca.xml

Loading...
Wildfire Games · Phabricator