Page MenuHomeWildfire Games

Allow buildings to autobuild themselves
ClosedPublic

Authored by Stan on Dec 21 2019, 12:15 PM.

Details

Reviewers
Angen
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23514: Allow buildings to autobuild themselves.
Summary

Currently you need to have builders to build buildings. This may sound logical, but consider buildings as living things, then they should grow by themselves.

This patch adds an autobuild flag, so that a placed foundation can build itself.

Question. This currently uses the builder component, meaning that such entity must also have one. This is done to remove duplication but it increases coupling. Should it be separated.

Test Plan

Add

<Buildable>
 <AutoBuild>
   <Rate>1</Rate>
 </AutoBuild>
</Buildable>

to a building of your choice, place its foundation, and check it builds by itself

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Stan updated this revision to Diff 11393.Wed, Feb 19, 8:11 AM

Invert condition check for rate !=0

Stan updated this revision to Diff 11394.Wed, Feb 19, 8:12 AM
Stan marked 9 inline comments as done.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 165| 165| 	this.totalBuilderRate += buildRate;
| 166| 166| 
| 167| 167| 	return true;
| 168|    |-}
|    | 168|+};
| 169| 169| 
| 170| 170| /**
| 171| 171|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 200| 200| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 201| 201| 
| 202| 202| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 203|    |-}
|    | 203|+};
| 204| 204| 
| 205| 205| /**
| 206| 206|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 168| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 203| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1789/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 165| 165| 	this.totalBuilderRate += buildRate;
| 166| 166| 
| 167| 167| 	return true;
| 168|    |-}
|    | 168|+};
| 169| 169| 
| 170| 170| /**
| 171| 171|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 200| 200| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 201| 201| 
| 202| 202| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 203|    |-}
|    | 203|+};
| 204| 204| 
| 205| 205| /**
| 206| 206|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 168| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 203| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1790/display/redirect

Angen requested changes to this revision.Wed, Feb 19, 7:18 PM

Autobuildable needs to watch for OnOwnershipChanged message and recalculate this.rate.
Else looks acceptable.

This revision now requires changes to proceed.Wed, Feb 19, 7:18 PM
Angen added a comment.Wed, Feb 19, 8:02 PM

almost missed

binaries/data/mods/public/simulation/components/AutoBuildable.js
5 ↗(On Diff #11394)

this.rate = applyvaluemodif...

Stan updated this revision to Diff 11395.Wed, Feb 19, 8:41 PM
Stan marked an inline comment as done.

Listen to onownershipchanged message

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 165| 165| 	this.totalBuilderRate += buildRate;
| 166| 166| 
| 167| 167| 	return true;
| 168|    |-}
|    | 168|+};
| 169| 169| 
| 170| 170| /**
| 171| 171|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 200| 200| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 201| 201| 
| 202| 202| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 203|    |-}
|    | 203|+};
| 204| 204| 
| 205| 205| /**
| 206| 206|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 168| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 203| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1791/display/redirect

For me and future me: Why is it a bad idea to have the Autobuild timer in the Autobuild component?

Angen requested changes to this revision.Thu, Feb 20, 7:51 PM

when rate drops to 0, gui shows remaining time but that is not correct information,
(maybe some autobuild icon or tooltip could be added as well)

This revision now requires changes to proceed.Thu, Feb 20, 7:51 PM
Stan added a comment.Thu, Feb 20, 9:39 PM

For me and future me: Why is it a bad idea to have the Autobuild timer in the Autobuild component?

It's not bad, it's not doable, because the foundation creates a preview entity, and that's the one you add builders to. The problem here is that one cannot access that preview entity.

But I sent you a paste last week which had the timer in the Autobuildable cmp. and that worked?

Stan updated this revision to Diff 11406.Thu, Feb 20, 9:53 PM
  • Cancel timers when rate is 0

But I sent you a paste last week which had the timer in the Autobuildable cmp. and that worked?

I don't know then, but the thing I tried failed, and if that paste isn't changing the preview entity, then it's changing behavior :)

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 165| 165| 	this.totalBuilderRate += buildRate;
| 166| 166| 
| 167| 167| 	return true;
| 168|    |-}
|    | 168|+};
| 169| 169| 
| 170| 170| /**
| 171| 171|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 200| 200| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 201| 201| 
| 202| 202| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 203|    |-}
|    | 203|+};
| 204| 204| 
| 205| 205| /**
| 206| 206|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 168| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 203| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1798/display/redirect

Stan updated this revision to Diff 11408.Thu, Feb 20, 11:11 PM

Fix broken check.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 165| 165| 	this.totalBuilderRate += buildRate;
| 166| 166| 
| 167| 167| 	return true;
| 168|    |-}
|    | 168|+};
| 169| 169| 
| 170| 170| /**
| 171| 171|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 200| 200| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 201| 201| 
| 202| 202| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 203|    |-}
|    | 203|+};
| 204| 204| 
| 205| 205| /**
| 206| 206|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 168| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 203| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1800/display/redirect

Angen requested changes to this revision.Fri, Feb 21, 7:51 AM
Angen added inline comments.
binaries/data/mods/public/simulation/components/Foundation.js
523 ↗(On Diff #11408)

this.CancelTimer means timer is running and we want to cancel it, right ? But if timer is running L518 executes early return so never gets here, also AutoBuild will cancel timer if rate reaches 0

525 ↗(On Diff #11408)

even if you cancel timer above when rate reaches 0, this line starts it again

This revision now requires changes to proceed.Fri, Feb 21, 7:51 AM
Stan updated this revision to Diff 11409.Fri, Feb 21, 8:28 AM

Remove cancelling

Stan marked 2 inline comments as done.Fri, Feb 21, 8:29 AM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 165| 165| 	this.totalBuilderRate += buildRate;
| 166| 166| 
| 167| 167| 	return true;
| 168|    |-}
|    | 168|+};
| 169| 169| 
| 170| 170| /**
| 171| 171|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 200| 200| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 201| 201| 
| 202| 202| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 203|    |-}
|    | 203|+};
| 204| 204| 
| 205| 205| /**
| 206| 206|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 168| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 203| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1801/display/redirect

Angen added a comment.Fri, Feb 21, 9:47 PM

part of autobuildable has class syntax and part prototype, should use one

binaries/data/mods/public/simulation/components/Foundation.js
506 ↗(On Diff #11409)

maybe !rate

Stan added a comment.Sat, Feb 22, 12:02 AM

Have to use both. Events are not supported in class syntax.

Stan marked an inline comment as done.Sat, Feb 22, 10:05 AM
Stan added inline comments.
binaries/data/mods/public/simulation/components/Foundation.js
506 ↗(On Diff #11409)

I'd rather not, as it would cover rate being negative.

Angen accepted this revision.Sun, Feb 23, 10:48 AM

Structure with autobuildable component builds without unit building it.
Modifications from technologies and auras apply correctly.

Feature requested for HC.

binaries/data/mods/public/simulation/components/Foundation.js
506 ↗(On Diff #11409)

!-5 == false

This revision is now accepted and ready to land.Sun, Feb 23, 10:48 AM
Stan marked an inline comment as done.EditedSun, Feb 23, 12:16 PM

@Freagarach, can you try your solution with the latest version of the patch? (To move the three functions)

Stan` shoots himself in the foot: Shouldn't this use Status Effects? Could be done in V2.

Thanks for the review Angen.

binaries/data/mods/public/simulation/components/Foundation.js
506 ↗(On Diff #11409)

@Angen should I change it then?

Angen added inline comments.Sun, Feb 23, 5:16 PM
binaries/data/mods/public/simulation/components/Foundation.js
506 ↗(On Diff #11409)

its not terrible or bad as it is so i leave that on you to decide and rate will always be defined

In D2492#110907, @Stan wrote:

@Freagarach, can you try your solution with the latest version of the patch? (To move the three functions)


(You'd need to update the Foundation test though.)

In D2492#110907, @Stan wrote:

Stan` shoots himself in the foot: Shouldn't this use Status Effects? Could be done in V2.

I'm not sure how one could use Status Effects for this?

Stan added a comment.Mon, Feb 24, 8:24 PM
In D2492#110907, @Stan wrote:

@Freagarach, can you try your solution with the latest version of the patch? (To move the three functions)


(You'd need to update the Foundation test though.)

In D2492#110907, @Stan wrote:

Stan` shoots himself in the foot: Shouldn't this use Status Effects? Could be done in V2.

I'm not sure how one could use Status Effects for this?

Add an autobuild status effect? Which deals construction damage

Stan updated this revision to Diff 11419.Tue, Feb 25, 1:12 AM

Move the code to the Autobuildable component to decouple it as much as possible.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 165| 165| 	this.totalBuilderRate += buildRate;
| 166| 166| 
| 167| 167| 	return true;
| 168|    |-}
|    | 168|+};
| 169| 169| 
| 170| 170| /**
| 171| 171|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 200| 200| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 201| 201| 
| 202| 202| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 203|    |-}
|    | 203|+};
| 204| 204| 
| 205| 205| /**
| 206| 206|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 168| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 203| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1810/display/redirect

Stan marked 2 inline comments as done.Tue, Feb 25, 1:23 AM
Stan updated this revision to Diff 11421.Tue, Feb 25, 1:27 AM

Remove more noise and coupling.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 162| 162| 	this.totalBuilderRate += buildRate;
| 163| 163| 
| 164| 164| 	return true;
| 165|    |-}
|    | 165|+};
| 166| 166| 
| 167| 167| /**
| 168| 168|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 197| 197| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 198| 198| 
| 199| 199| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 200|    |-}
|    | 200|+};
| 201| 201| 
| 202| 202| /**
| 203| 203|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 165| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 200| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 370| »   »   var·pos·=·cmpPosition.GetPosition2D();
|    | [NORMAL] JSHintBear:
|    | 'pos' is already defined.

binaries/data/mods/public/simulation/components/Foundation.js
| 372| »   »   var·rot·=·cmpPosition.GetRotation();
|    | [NORMAL] JSHintBear:
|    | 'rot' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1811/display/redirect

Angen added a comment.Tue, Feb 25, 7:48 AM

can you request review ?

Stan requested review of this revision.Tue, Feb 25, 8:23 AM
Stan updated this revision to Diff 11422.

Remove message code.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 162| 162| 	this.totalBuilderRate += buildRate;
| 163| 163| 
| 164| 164| 	return true;
| 165|    |-}
|    | 165|+};
| 166| 166| 
| 167| 167| /**
| 168| 168|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 197| 197| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 198| 198| 
| 199| 199| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 200|    |-}
|    | 200|+};
| 201| 201| 
| 202| 202| /**
| 203| 203|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 165| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 200| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 370| »   »   var·pos·=·cmpPosition.GetPosition2D();
|    | [NORMAL] JSHintBear:
|    | 'pos' is already defined.

binaries/data/mods/public/simulation/components/Foundation.js
| 372| »   »   var·rot·=·cmpPosition.GetRotation();
|    | [NORMAL] JSHintBear:
|    | 'rot' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1812/display/redirect

Angen added inline comments.Tue, Feb 25, 11:56 AM
binaries/data/mods/public/simulation/components/AutoBuildable.js
70 ↗(On Diff #11422)

this should now use this.rate dirrectly, same above

Freagarach added inline comments.Tue, Feb 25, 7:34 PM
binaries/data/mods/public/simulation/components/AutoBuildable.js
39 ↗(On Diff #11422)

If you use this.rate you can combine the two ifs :)

47 ↗(On Diff #11422)

Could we possible deconstruct the AutoBuildable component when there is no cmpFoundation?

Stan updated this revision to Diff 11425.Tue, Feb 25, 8:07 PM

Remove usage of this.GetRate()

Stan marked 3 inline comments as done.Tue, Feb 25, 8:07 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1294/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1813/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/macos-differential/390/display/redirect

Stan updated this revision to Diff 11427.Tue, Feb 25, 8:12 PM

Fix missing this.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 162| 162| 	this.totalBuilderRate += buildRate;
| 163| 163| 
| 164| 164| 	return true;
| 165|    |-}
|    | 165|+};
| 166| 166| 
| 167| 167| /**
| 168| 168|  * Adds a builder to the counter.
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/simulation/components/Foundation.js
| 197| 197| 		cmpVisual.SetVariable("numbuilders", this.builders.size);
| 198| 198| 
| 199| 199| 	Engine.PostMessage(this.entity, MT_FoundationBuildersChanged, { "to": this.GetBuilders() });
| 200|    |-}
|    | 200|+};
| 201| 201| 
| 202| 202| /**
| 203| 203|  * The build multiplier is a penalty that is applied to each builder.

binaries/data/mods/public/simulation/components/Foundation.js
| 165| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 200| }
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

binaries/data/mods/public/simulation/components/Foundation.js
| 370| »   »   var·pos·=·cmpPosition.GetPosition2D();
|    | [NORMAL] JSHintBear:
|    | 'pos' is already defined.

binaries/data/mods/public/simulation/components/Foundation.js
| 372| »   »   var·rot·=·cmpPosition.GetRotation();
|    | [NORMAL] JSHintBear:
|    | 'rot' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1814/display/redirect

Stan updated this revision to Diff 11430.Tue, Feb 25, 9:39 PM

Remove template change.

Angen accepted this revision.Tue, Feb 25, 9:39 PM
This revision is now accepted and ready to land.Tue, Feb 25, 9:39 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1817/display/redirect

This revision was landed with ongoing or failed builds.Tue, Feb 25, 10:30 PM
This revision was automatically updated to reflect the committed changes.