The Briton champion cavalry is, in fact, a chariot, and ought to be named as such; cf.
maur_champion_chariot.xml and sele_champion_chariot.xml.
This patch therefore moves brit_champion_cavalry.xml to brit_champion_chariot.xml and updates all files that use it accordingly.
Details
Details
- Reviewers
Stan bb - Commits
- rP23716: Rename brit_champion_cavalry* to brit_champion_chariot*
Check for mistakes and omissions.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1451/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/933/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/28/display/redirect
Comment Actions
Might,
@Angen: Petra doesn't use template names right? Cause the last time I changed cavalry to camelry it did not go well... (rP21275)
Comment Actions
Petra doesn't use template names right?
It does for structures, merchant ships, traders, and healers (which is annoying), but not for other units.
Comment Actions
It means you can train brit chariots at all structures that can champion chariots (e.g. maur and sele fortresses), but no longer at structures that can train champion cavalry (e.g. gaul, iber, mace, rome fortress and barracks). And vice versa: champion cavalry can no longer be trained at the brit fortress and barracks, but enemy chariots can.
If you want to be able to train infantry, cavalry, and chariot champions at all enemy barracks, then the correct way would be to insert those in the production queue of the parent barracks. I could make a patch for that.
Comment Actions
Isn't that unbalanced then? Cause there is more cavalry than chariots therefore making it more rewarding for some civs?
Comment Actions
It is unbalanced right now without this patch and it will remain unbalanced with this patch, albeit slightly less.
Comment Actions
To give a better idea, let's lists which structures can train which champions.
champion chariot: from 2 to 4:
+ brit_barracks + brit_fortress maur_fortress sele_fortress
champion cavalry: from 15 to 13:
- brit_barracks - brit_fortress cart_temple cart_tophet gaul_barracks gaul_fortress iber_barracks iber_fortress mace_barracks mace_fortress pers_fortress ptol_fortress rome_barracks rome_fortress sele_fortress
champion infantry: at 15:
athen_gymnasium brit_barracks brit_fortress cart_temple cart_tophet gaul_barracks gaul_fortress iber_barracks iber_fortress kush_fortress maur_barracks maur_fortress pers_apadana rome_barracks rome_fortress
D2547 allows training all barracks champions at any barracks.
Comment Actions
We should wait for that patch to be accepted then. Another trivial change that could change gameplay because of me being careless...
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2272/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/1741/display/redirect
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/874/display/redirect
Comment Actions
All champion chariots similar now. Won't affect gameplay too much, since we only group brit with maur and sele now, instead of with the rest of them.