Page MenuHomeWildfire Games

[gameplay] separate chariot templates
Needs RevisionPublic

Authored by Nescio on Aug 17 2020, 2:36 PM.

Details

Reviewers
borg-
Group Reviewers
Balancing
Summary

This patch separates chariots from cavalry by creating the following templates:

template_unit_champion_chariot.xml
template_unit_champion_chariot_archer.xml
template_unit_champion_chariot_javelineer.xml
template_unit_hero_chariot.xml
template_unit_hero_chariot_archer.xml
template_unit_hero_chariot_javelineer.xml

This allows further differentiation. Chariots:

  • no longer have a Cavalry class, which means they don't benefit from cavalry auras and technologies (neither do dogs and elephants);
  • keep the same attacks and movement speed as cavalry;
  • have slightly more armour than cavalry (champion +1/+3/+0, hero +0/+2/+0);
  • champion chariots have double health but cost more:
             inf , cav , cha , ele
food       :  80 , 150 , 200 , 300
wood       :  60 ,  80 , 160 ,
metal      :  80 , 100 , 120 , 200
population :   1 ,   1 ,   2 ,   3
time       :  20 ,  30 ,  30 ,  30
health     : 100 , 240 , 500 , 750
experience : 150 , 200 , 250 , 300

As you can see champion chariots have values something in between cavalry and elephants.

Test Plan

Check for compleness and correctness. Agree with the proposed changes.

Event Timeline

Nescio created this revision.Aug 17 2020, 2:36 PM
Owners added a subscriber: Restricted Owners Package.Aug 17 2020, 2:36 PM

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
<command-line>:0:0: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[1]: *** [obj/test_Debug/test_root.o] Error 1
make: *** [test] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3009/display/redirect

Nescio requested review of this revision.Aug 17 2020, 2:40 PM
Nescio updated this revision to Diff 13227.Aug 17 2020, 2:41 PM
Nescio edited the summary of this revision. (Show Details)
Nescio added inline comments.
binaries/data/mods/public/simulation/templates/template_unit_champion_cavalry_archer.xml
34 ↗(On Diff #13227)

Already defined in its parent.

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
<command-line>:0:0: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[1]: *** [obj/test_Debug/test_root.o] Error 1
make: *** [test] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3010/display/redirect

Nescio updated this revision to Diff 13228.Aug 17 2020, 2:50 PM
Nescio edited the summary of this revision. (Show Details)
  • undo arrow sound clean-up (belongs in a separate patch)

Build failure - The Moirai have given mortals hearts that can endure.

builderr-debug-gcc6.txt
<command-line>:0:0: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[1]: *** [obj/test_Debug/test_root.o] Error 1
make: *** [test] Error 2

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/3011/display/redirect

borg- added a subscriber: borg-.Aug 18 2020, 12:08 AM

Separating the templates is a good thing for the future where we can have techonologies and specific auras, but like D2900 I don't like the fact that they are not affected by technologies or auras. Camels are considered cavalry, as are elephants and chariots (they are drawn by horses).

About the attributes, I think chariots would be interesting and more real that it need 2 pop as a penalty for its armor and greater health.

About the attributes, I think chariots would be interesting and more real that it need 2 pop as a penalty for its armor and greater health.

Actually it does, see the relevant line in the templates (and also the summary).

Separating the templates is a good thing for the future where we can have techonologies and specific auras, but like D2900 I don't like the fact that they are not affected by technologies or auras. Camels are considered cavalry, as are elephants and chariots (they are drawn by horses).

As mentioned over there, the point of separating templates is differentiation. If chariots are functionally identical to and benefit from the same things as cavalry, then why bother splitting them? Their much higher base stats ought to be a decent compensation for their lack of technologies. Besides, chariot-specific technologies can be added in the future.

binaries/data/mods/public/simulation/templates/template_unit_champion_chariot.xml
9

I still my opnion, don't like the fact that they are not affected by technologies or auras.

Then you may request changes, such that it does not linger in our review queue :)

borg- requested changes to this revision.Feb 9 2021, 1:39 PM

It makes no sense to me that chariots do not benefit from hourses techs, auras etc.
I think the status changes can be made directly in the templates without the need to create new ones.

This revision now requires changes to proceed.Feb 9 2021, 1:39 PM
borg- added a comment.EditedFeb 9 2021, 1:42 PM

It doesn't make sense to me to have unlock_champion_chariots and unlock_champion_cavalry (both are cavalry). It is the same as having a techonology for swordmen and another for spearmen, or archer, both are infantry. So to make sense of unlock_champion_chariots i would like to see these status changes in the templates already for a24. A patch with only status changes should not be a risk for committing.

What do you mean with “status changes”?

borg- added a comment.EditedFeb 10 2021, 2:18 PM

What do you mean with “status changes”?

Health, pop cost, res cost, etc..

Sure, such attribute values could be changed in a separate patch. It's not terribly important, though, more something for A25.
What do you think would be appropiate resource and time costs? Also for heroes?

Yes, it is not something terrible, but it can be fixed with a certain "ease" and makes a24 even better.
I thought of few changes, just pop cost and health.
Health +30% and pop cost 2? No affect heros.