Reuse "APPROACHING"-state in formation combat.
ClosedPublic
Actions

Authored by Freagarach on Sep 4 2020, 10:49 AM.

Details

Reviewers

Silier
wraitii
bb

Commits

rP24032: Reuse "APPROACHING"-state in formation combat.

Summary

Noticed by @wraitii in D1971#inline-53877.

Test Plan

Verify this is correct and formation can still attack and follow targets.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Freagarach created this revision.Sep 4 2020, 10:49 AM

Harbormaster completed remote builds in B13079: Diff 13389.Sep 4 2020, 10:55 AM

Freagarach requested review of this revision.Sep 4 2020, 10:55 AM

Looks correct from the code, individuals do the same too.
Checking all pushOrderFront calls in the unitIA shows this patch is complete

This revision is now accepted and ready to land.Sep 4 2020, 11:17 PM

nice find

Closed by commit rP24032: Reuse "APPROACHING"-state in formation combat. (authored by Freagarach). · Explain WhySep 10 2020, 9:51 AM

This revision was automatically updated to reflect the committed changes.

Freagarach added a commit: rP24032: Reuse "APPROACHING"-state in formation combat..

Thanks for the review @Angen and @bb :)

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

components/

UnitAI.js

6 lines

Diff 13460

View Options

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Reuse "APPROACHING"-state in formation combat.ClosedPublicActions