Page MenuHomeWildfire Games

[gameplay] set plane <BuffHeal> to 0
Needs ReviewPublic

Authored by Nescio on Jan 9 2021, 2:23 PM.


Group Reviewers

This patch is split off from D3264/rP24523. It changes the P-51 Mustang's <GarrisonHolder/BuffHeal> from 1 to 0. For comparison, ships, siege towers and rams have a buff heal of 0 as well.
The plane received the relevant node years ago, but neither the commit message (rP13694) nor the trac ticket (#2067) mentiones the buff heal of 1, nor explains why. (I suspect it's simply the result of being copied from a structure template.)

Test Plan

Agree this is an improvement.

Event Timeline

Nescio created this revision.Jan 9 2021, 2:23 PM
Owners added a subscriber: Restricted Owners Package.Jan 9 2021, 2:24 PM
Vulcan added a comment.Jan 9 2021, 2:44 PM

Build is green

/Applications/ file: ../../../binaries/system/libsimulation2_dbg.a(precompiled.o) has no symbols
/Applications/ file: ../../../binaries/system/libengine_dbg.a(precompiled.o) has no symbols
/Applications/ file: ../../../binaries/system/libgraphics_dbg.a(precompiled.o) has no symbols
/Applications/ file: ../../../binaries/system/libatlas_dbg.a(precompiled.o) has no symbols
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/F

See for more details.

Nescio requested review of this revision.Jan 9 2021, 2:44 PM
Freagarach added a comment.EditedJan 23 2021, 8:24 AM

I'm opposed, as it is a nice bonus for a cheat unit. That being said, if someone disagrees with mee, feel free to commit (I won't).

(Also I think the [gameplay] tag is not very appropriate here, since it is cheat unit.)