HomeWildfire Games

[Gameplay A24] - Unify garrison heal rates.
AuditedrP24523

Description

[Gameplay A24] - Unify garrison heal rates.

Makes all (standard) structures don't heal at first, execept for the wonder (heal rate of 5) and temple (3).
Replaces the barracks healing technology by one that allows healing in all structures (+1).

Summarising:
This patch makes the 0 rate the default and merges the technologies to a single one, researchable at the temple, but affecting garrisoned units in all structures, except for outposts and walls (i.e. those with visible turret points). The new situation is:

0: structures by default
1: structures with technology
3: temple by default
4: temple with technology
5: wonder by default
6: wonder with technology

Patch by: @Nescio
Differential revision: D3264
Reviewed by: @borg-

Event Timeline

Silier raised a concern with this commit.Jan 9 2021, 1:30 PM
Silier added a subscriber: Silier.

Hi,
you forgot something somewhere :)
open structure tree
ERROR: File 'simulation/data/technologies/garrison.json' does not exist

ERROR: Errors executing script event "SelectionChange"

ERROR: JavaScript error: gui/reference/common/TemplateLoader.js line 267 this.loadTechnologyTemplate(...) is undefined isPairTech@gui/reference/common/TemplateLoader.js:267:17 deriveProductionQueue@gui/reference/common/TemplateLoader.js:142:14 deriveTemplateListsFromTemplate@gui/reference/common/TemplateLister.js:121:43 compileTemplateLists@gui/reference/common/TemplateLister.js:39:21 setActiveCiv@gui/reference/common/ReferencePage.js:26:51 selectCiv@gui/reference/structree/StructreePage.js:47:8 onSelectionChange@gui/reference/common/Dropdowns/CivSelectDropdown.js:26:11 CivSelectDropdown/this.civSelection.onSelectionChange@gui/reference/common/Dropdowns/CivSelectDropdown.js:18:52 selectFirstCiv@gui/reference/common/Dropdowns/CivSelectDropdown.js:58:3 init@gui/reference/structree/structree.js:13:23 onPress@gui/pregame/MainMenuItems.js:32:13 performButtonAction@gui/pregame/MainMenuItemHandler.js:77:9 pressButton@gui/pregame/MainMenuItemHandler.js:63:10

This commit now has outstanding concerns.Jan 9 2021, 1:30 PM
Silier added inline comments.Jan 9 2021, 1:31 PM
/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_temple.xml
55

^

Nescio added inline comments.
/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_temple.xml
55

Oops, how sloppy, an underscope (_) should have been used, not a space, obviously. Here you go: D3308.

Silier accepted this commit.Jan 9 2021, 4:28 PM
All concerns with this commit have now been addressed.Jan 9 2021, 4:28 PM
Freagarach added inline comments.Jan 10 2021, 7:49 AM
/ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_civic_temple.xml
55

We even discussed this specific line xD