Page MenuHomeWildfire Games

[gameplay] deprecate gaul tavern
ClosedPublic

Authored by Nescio on Jan 10 2021, 4:07 PM.

Details

Summary

As pointed out by @genava55 in this forum post, taverns in Gaul first appeared in the 1st C BC as a consequence of growing Roman influence. It's thus not exactly accurate (pre-Roman) Gauls in 0 A.D. can build them by default.
This patch therefore deprecates the tavern (keeping it for scenarios only) and moves the champion fanatics to the temple (cf. cart, kush).

Test Plan

Agree this is an improvement.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 10 2021, 4:07 PM
Owners added a subscriber: Restricted Owners Package.Jan 10 2021, 4:07 PM
Nescio added inline comments.Jan 10 2021, 4:08 PM
binaries/data/mods/public/simulation/templates/structures/gaul/tavern.xml
51 ↗(On Diff #15102)

While city walls and wonders have maximum territory weight, that's not really appropiate for a tavern.

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2748/display/redirect for more details.

Nescio requested review of this revision.Jan 10 2021, 4:12 PM
borg- added a subscriber: borg-.Jan 10 2021, 4:44 PM

Does it make historical sense to keep fanatics in the temples? if it is just for balance, we can increase its cost by being a p2 unit.

Does it make historical sense to keep fanatics in the temples?

Not really that much (see forum post), but the barracks makes even less sense.
I wouldn't mind simply deprecating the fanatic as well, but people are already complaining civs are rather similar (they're right).

borg- added a comment.Jan 10 2021, 6:07 PM

If it doesn’t make historical sense to train at the temple then the barracks is the most correct place for that.
We have in mind a patch to change champions from fortress to barracks, perhaps this should also apply to those who are trained in the temples. Anyway i am a favor of the patch, if it doesn't make historical sense it must be reassembled or replaced.

If it doesn’t make historical sense to train at the temple then the barracks is the most correct place for that.

The temple is the location @genava55 more than once recommended, hence why I didn't opt for the barracks.

We have in mind a patch to change champions from fortress to barracks, perhaps this should also apply to those who are trained in the temples.

Some civs already have specific structures in the city phase at which they can train their champions (e.g. athen gymnasium, pers apadana, spart syssition). Ideally all would, but new structures require new art, which is not trivial.

Stan added a subscriber: Stan.Jan 10 2021, 7:30 PM

IMHO Fanatics should stay in temple for the time being. What is the assembly currently used for ? Should we allow the carnyx player to be recruited from there? IIRC the files are committed, and the actor can be taken from DE. Remaining is template work.

What is the assembly currently used for ?

You mean the gaul theatre? It's not buildable at the moment.

Should we allow the carnyx player to be recruited from there? IIRC the files are committed, and the actor can be taken from DE. Remaining is template work.

I'm not exactly sure what you mean; feel free to make a patch.

Stan added a comment.Jan 10 2021, 7:42 PM

Yeah that's the one.

Okay, let's see.

borg- added a comment.Jan 10 2021, 8:32 PM

I have carnyx on my mod. My Idea for carnyx is a aura giving capture rate bônus for units.

borg- accepted this revision.Jan 11 2021, 4:17 AM

It does not affect the balance because construction is still required for training. Historical inconsistencies must be removed / changed, so I agree, it was even requested by me on the forum.

This revision is now accepted and ready to land.Jan 11 2021, 4:17 AM
This revision was automatically updated to reflect the committed changes.