Page MenuHomeWildfire Games

Allow setting modifiers while upgrading.
Needs ReviewPublic

Authored by wraitii on Jan 19 2021, 2:07 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

As noted regularly, upgrading is powerful because it requires no workers.
This diff allows setting modifiers on the upgrading entity while it is being upgraded, which can make the choice to upgrade more tactical.

It introduces upgrade for Cart houses to Appartment, by temporarily lowering population (NB: there's no checking here, so the pop limit can be 'cheated' a bit).

Could/Should also be used for tower upgrades (do we have those?) and so on IMO.

TODO:

  • Would perhaps be nice to set this as a status effect so we can have an icon? 'Tis a bigger diff.
Test Plan

Agree that this is a nice feature.

Event Timeline

wraitii created this revision.Jan 19 2021, 2:07 PM
Owners added a subscriber: Restricted Owners Package.Jan 19 2021, 2:07 PM

Build is green

builderr-debug-macos.txt
ld: warning: text-based stub file /System/Library/Frameworks//CoreAudio.framework/CoreAudio.tbd and library file /System/Library/Frameworks//CoreAudio.framework/CoreAudio are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox.tbd and library file /System/Library/Frameworks//AudioToolbox.framework/AudioToolbox are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback.tbd and library file /System/Library/Frameworks//ForceFeedback.framework/ForceFeedback are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//CoreVideo.framework/CoreVideo.tbd and library file /System/Library/Frameworks//CoreVideo.framework/CoreVideo are out of sync. Falling back to library file for linking.
ld: warning: text-based stu

See https://jenkins.wildfiregames.com/job/macos-differential/2967/display/redirect for more details.

wraitii requested review of this revision.Jan 19 2021, 2:20 PM
Stan added a subscriber: Stan.Jan 19 2021, 2:21 PM

What kind of icons would you need?

In D3424#151616, @Stan wrote:

What kind of icons would you need?

It's more of a JS concern, modifiers don't appear in the GUI, whereas status effects do.

Stan added a comment.Jan 19 2021, 2:27 PM

Kind of feel like the duplication should be reduced no?

In D3424#151620, @Stan wrote:

Kind of feel like the duplication should be reduced no?

There's no duplication?