Page MenuHomeWildfire Games

Delete the broken unused marker_object_sound template
ClosedPublic

Authored by Stan on May 3 2017, 4:30 PM.

Details

Summary

In rP15356 was introduced some atlas marker (actors and templates)
In rP15361 all of them expecting the sound one were renamed and rebased.
Currently special/marker_object_sound.xml doesn't validate, has a strange inheritance, is not in the placeable filter and is unused.
I suggest to remove that forgotten template and to keep the related actor. If someone has such a need, he could then do it in the needed way.

Test Plan

-

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fatherbushido created this revision.May 3 2017, 4:30 PM
elexis added a subscriber: elexis.May 3 2017, 4:37 PM

Perhaps you can recapitulate the response from Pureon about this entity too for the others.

rP14231 introduced a dummy.xml in the same directory which doesn't seem used anymore, nor useful

vladislavbelov requested changes to this revision.EditedMay 3 2017, 4:46 PM
vladislavbelov added a subscriber: vladislavbelov.

Then you have to remove related objects too (since they're not used somewhere else): props/special/common/marker_object_sound.xml, props/special/marker_object_sound.dae.
Or fix this template.

This revision now requires changes to proceed.May 3 2017, 4:46 PM
fatherbushido abandoned this revision.May 3 2017, 4:48 PM
elexis added a subscriber: Sandarac.May 3 2017, 4:49 PM

The model looks identical, so could be removed even if the template was useful.
The current template is broken, so removing wouldn't be too far off, so if @Sandarac wants to use it for P41, it could be reintroduced, but this time not inheriting template_strucutre etc.

Vulcan added a subscriber: Vulcan.May 3 2017, 9:08 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/978/ for more details.

fatherbushido reclaimed this revision.May 5 2017, 10:22 PM
This revision now requires changes to proceed.May 5 2017, 10:22 PM
Stan commandeered this revision.May 6 2017, 3:10 PM
Stan added a reviewer: fatherbushido.
Stan added a subscriber: Stan.

Taking control of it as decided with fatherbushido.

Vulcan added a comment.May 6 2017, 3:58 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1035/ for more details.

Stan updated this revision to Diff 1688.May 6 2017, 4:30 PM

Remove the other three files mentionned above.

This revision was automatically updated to reflect the committed changes.