In rP15356 was introduced some atlas marker (actors and templates)
In rP15361 all of them expecting the sound one were renamed and rebased.
Currently special/marker_object_sound.xml doesn't validate, has a strange inheritance, is not in the placeable filter and is unused.
I suggest to remove that forgotten template and to keep the related actor. If someone has such a need, he could then do it in the needed way.
Details
Details
-
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Perhaps you can recapitulate the response from Pureon about this entity too for the others.
rP14231 introduced a dummy.xml in the same directory which doesn't seem used anymore, nor useful
Comment Actions
Then you have to remove related objects too (since they're not used somewhere else): props/special/common/marker_object_sound.xml, props/special/marker_object_sound.dae.
Or fix this template.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/978/ for more details.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/1035/ for more details.