Make these few places do what the rest of the codebase does.
Details
- Reviewers
Sandarac - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP19534: Pass CVector3D as const reference in a few places.
Compile, check that it does the same.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
source/graphics/Camera.cpp | ||
---|---|---|
364 ↗ | (On Diff #1636) | The use of orientation here is what causes the breakage (since this one isn't normalized, but should be). Nice catch! |
source/graphics/Camera.cpp | ||
---|---|---|
364 ↗ | (On Diff #1636) | Actually the use of up is broken too... |
source/graphics/Camera.cpp | ||
---|---|---|
364 ↗ | (On Diff #1636) | Not only, orientation should be normalized too (it doesn't without normalization, I've tested). Also it'd be not bad to normalize s too, I think. |
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/997/ for more details.
Keep two parameters as copies, since otherwise we'd just have to create a copy right afterwards.
source/graphics/Camera.cpp | ||
---|---|---|
364 ↗ | (On Diff #1636) | Actually keeping orientation and up as pass-by-value, since otherwise we'd just have to create a copy right afterwards. |
Build has FAILED
Link to build: http://jw:8080/job/phabricator/1079/
See console output for more information: http://jw:8080/job/phabricator/1079/console