Fix wxWidgets compatibility
ClosedPublic
Actions

Authored by vladislavbelov on May 5 2017, 1:18 AM.

Details

Reviewers

elexis
Itms
• leper

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP19525: Make r19427 compatible with wxWidgets 2.8, patch by vladislavbelov.
rP19427: List, add and delete cinematic paths in Atlas.

Summary

Fixed:

// wxWidget 2.9
std::wstring s = wxWidget::toStdWString();

// wxWidget 2.8
std::wstring s = wxString::wс_str();

Test Plan

Run atlas
Try to add/delete a path

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.May 5 2017, 1:18 AM

elexis awarded a token.May 5 2017, 1:29 AM

vladislavbelov edited the summary of this revision. (Show Details)May 5 2017, 1:57 AM

vladislavbelov added a commit: rP19427: List, add and delete cinematic paths in Atlas..

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (306 tests)..................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/1013/ for more details.

Harbormaster completed remote builds in B1457: Diff 1656.May 5 2017, 9:20 AM

vladislavbelov added 1 blocking reviewer(s): Restricted Owners Package.May 6 2017, 4:20 PM

vladislavbelov removed 1 blocking reviewer(s): Restricted Owners Package.May 7 2017, 5:33 PM

Thanks for the patch!

This revision is now accepted and ready to land.May 7 2017, 5:44 PM

Closed by commit rP19525: Make r19427 compatible with wxWidgets 2.8, patch by vladislavbelov. (authored by Itms). · Explain WhyMay 7 2017, 5:50 PM

This revision was automatically updated to reflect the committed changes.

Itms mentioned this in rP19427: List, add and delete cinematic paths in Atlas..May 7 2017, 5:51 PM