Replace the numerous internal functions registered in various places with a singular interface
Details
- Reviewers
- None
Build & Run (both debug and release)
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 20152 Build 48413: Vulcan Build Jenkins Build 48412: Vulcan Build (macOS) Jenkins Build 48411: Vulcan Build (Windows)
Event Timeline
Needs the CParamNode related changes. See https://irclogs.wildfiregames.com/%230ad-dev/2022-04-20-QuakeNet-%230ad-dev.log for more information.
17:45 < smiley> Stan: CParamNode is the culprit in D4486 btw. And its broken in release too. I suppose you also encountered it considering that you put an uneval log call and the Identity null check.
17:45 < WildfireBot`> D4486: Fix maps after rP26298. [Needs Review] – https://code.wildfiregames.com/D4486
17:45 < smiley> CParamNode does not take into account that ToJSVal might be called from different contexts.
17:47 < smiley> It previously because everything that had its own scriptinterface also kept its own templateLoader. I refactored it to be a namespace and ported parts of the patch on top of it and thats what i found.
17:47 < smiley> + previously worked
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/5948/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/7644/display/redirect
I think the build never finished because of
E:\Jenkins\workspace\vs2015-differential>binaries\system\test_dbg.exe 1>cxxtest_debug.xml Hit MOZ_CRASH(*** Compartment mismatch 03998430 vs. 03997A30 at argument 0) at e:/0ad/libraries/source/spidermonkey/mozjs-78.6.0/js/src\vm/JSContext-inl.h:61
Need to trigger a rebuild somehow. This revision wouldn't be updated often. The parent revision would have most of the actual changes related to this.