Page MenuHomeWildfire Games

Add JSI_TemplateLoader

Authored by lyv on Apr 20 2022, 8:04 PM.



Replace the numerous internal functions registered in various places with a singular interface

Test Plan

Build & Run (both debug and release)

Event Timeline

lyv created this revision.Apr 20 2022, 8:04 PM

Needs the CParamNode related changes. See for more information.

17:45 < smiley> Stan: CParamNode is the culprit in D4486 btw. And its broken in release too. I suppose you also encountered it considering that you put an uneval log call and the Identity null check.
17:45 < WildfireBot`> D4486: Fix maps after rP26298. [Needs Review] –
17:45 < smiley> CParamNode does not take into account that ToJSVal might be called from different contexts.
17:47 < smiley> It previously because everything that had its own scriptinterface also kept its own templateLoader. I refactored it to be a namespace and ported parts of the patch on top of it and thats what i found.
17:47 < smiley> + previously worked

Build failure - The Moirai have given mortals hearts that can endure.

Link to build:

Build failure - The Moirai have given mortals hearts that can endure.

Link to build:

lyv retitled this revision from [WIP] Add JSI_TemplateLoader to Add JSI_TemplateLoader.Apr 20 2022, 10:48 PM
Stan published this revision for review.Apr 21 2022, 8:30 AM
Stan added a subscriber: Stan.Apr 21 2022, 6:19 PM

I think the build never finished because of

E:\Jenkins\workspace\vs2015-differential>binaries\system\test_dbg.exe  1>cxxtest_debug.xml 
Hit MOZ_CRASH(*** Compartment mismatch 03998430 vs. 03997A30 at argument 0) at e:/0ad/libraries/source/spidermonkey/mozjs-78.6.0/js/src\vm/JSContext-inl.h:61
lyv added a comment.Apr 21 2022, 7:01 PM

Need to trigger a rebuild somehow. This revision wouldn't be updated often. The parent revision would have most of the actual changes related to this.